mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bisect--helper: remove "--next-vars" option as it is now useless

Browse Source 
Because it has been replaced by "--next-exit".

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Christian Couder
2009-04-21 07:54:09 +02:00
committed by Junio C Hamano
parent 5a1d31c7e4
commit c99f069de2
3 changed files with 3 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
bisect.c
View File

@ -554,21 +554,6 @@ static void bisect_common(struct rev_info *revs, const char *prefix,
!!skipped_sha1_nr); !!skipped_sha1_nr);
} }
int bisect_next_vars(const char *prefix)
{
struct rev_info revs;
struct rev_list_info info;
int reaches = 0, all = 0;
memset(&info, 0, sizeof(info));
info.revs = &revs;
info.bisect_show_flags = BISECT_SHOW_TRIED | BISECT_SHOW_STRINGED;
bisect_common(&revs, prefix, &reaches, &all);
return show_bisect_vars(&info, reaches, all);
}
static void exit_if_skipped_commits(struct commit_list *tried, static void exit_if_skipped_commits(struct commit_list *tried,
const unsigned char *bad) const unsigned char *bad)
{ {

1
bisect.h
View File

@ -28,7 +28,6 @@ struct rev_list_info {
extern int show_bisect_vars(struct rev_list_info *info, int reaches, int all); extern int show_bisect_vars(struct rev_list_info *info, int reaches, int all);
extern int bisect_next_vars(const char *prefix);
extern int bisect_next_exit(const char *prefix); extern int bisect_next_exit(const char *prefix);
extern int estimate_bisect_steps(int all); extern int estimate_bisect_steps(int all);

10
builtin-bisect--helper.c
View File

@ -4,18 +4,14 @@
#include "bisect.h" #include "bisect.h"
static const char * const git_bisect_helper_usage[] = { static const char * const git_bisect_helper_usage[] = {
"git bisect--helper --next-vars",
"git bisect--helper --next-exit", "git bisect--helper --next-exit",
NULL NULL
}; };
int cmd_bisect__helper(int argc, const char **argv, const char *prefix) int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
{ {
int next_vars = 0;
int next_exit = 0; int next_exit = 0;
struct option options[] = { struct option options[] = {
OPT_BOOLEAN(0, "next-vars", &next_vars,
"output next bisect step variables"),
OPT_BOOLEAN(0, "next-exit", &next_exit, OPT_BOOLEAN(0, "next-exit", &next_exit,
"output bisect result and exit instuctions"), "output bisect result and exit instuctions"),
OPT_END() OPT_END()
@ -23,11 +19,9 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
argc = parse_options(argc, argv, options, git_bisect_helper_usage, 0); argc = parse_options(argc, argv, options, git_bisect_helper_usage, 0);
if ((next_vars && next_exit) || (!next_vars && !next_exit)) if (!next_exit)
usage_with_options(git_bisect_helper_usage, options); usage_with_options(git_bisect_helper_usage, options);
if (next_vars) /* next-exit */
return bisect_next_vars(prefix);
else /* next-exit */
return bisect_next_exit(prefix); return bisect_next_exit(prefix);
} }