mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drop pure pass-through config callbacks

Browse Source 
Commit fd2d4c135e (gpg-interface: lazily initialize and read the
configuration, 2023-02-09) shrunk a few custom config callbacks so that
they are just one-liners of:

  return git_default_config(...);

We can drop them entirely and replace them direct calls of
git_default_config() intead. This makes the code a little shorter and
easier to understand (with the downside being that if they do grow
custom options again later, we'll have to recreate the functions).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King
2023-02-26 17:40:46 -05:00
committed by Junio C Hamano
parent fd2d4c135e
commit cc5d1d32fd
4 changed files with 4 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
builtin/commit-tree.c
View File

@ -37,11 +37,6 @@ static void new_parent(struct commit *parent, struct commit_list **parents_p)
commit_list_insert(parent, parents_p);
}
static int commit_tree_config(const char *var, const char *value, void *cb)
{
return git_default_config(var, value, cb);
}
static int parse_parent_arg_callback(const struct option *opt,
const char *arg, int unset)
{
@ -118,7 +113,7 @@ int cmd_commit_tree(int argc, const char **argv, const char *prefix)
OPT_END()
};
git_config(commit_tree_config, NULL);
git_config(git_default_config, NULL);
if (argc < 2 || !strcmp(argv[1], "-h"))
usage_with_options(commit_tree_usage, options);