Redirect update hook stdout to stderr.
If an update hook outputs to stdout then that output will be sent back over the wire to the push client as though it were part of the git protocol. This tends to cause protocol errors on the client end of the connection, as the hook output is not expected in that context. Most hook developers work around this by making sure their hook outputs everything to stderr. But hooks shouldn't need to perform such special behavior. Instead we can just dup stderr to stdout prior to invoking the update hook. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
committed by
Junio C Hamano
parent
9b0b50936e
commit
cd83c74cb3
@ -13,8 +13,10 @@ enum {
|
||||
|
||||
#define RUN_COMMAND_NO_STDIO 1
|
||||
#define RUN_GIT_CMD 2 /*If this is to be git sub-command */
|
||||
#define RUN_COMMAND_STDOUT_TO_STDERR 4
|
||||
int run_command_v_opt(const char **argv, int opt);
|
||||
int run_command_v(const char **argv);
|
||||
int run_command_opt(int opt, const char *cmd, ...);
|
||||
int run_command(const char *cmd, ...);
|
||||
|
||||
#endif
|
||||
|
||||
Reference in New Issue
Block a user