mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

url.c: "<scheme>://" part at the beginning should not be URL decoded

Browse Source 
When using the protocol git+ssh:// for example we do not want to
decode the '+' as a space. The url decoding must take place only
for the server name and parameters.

This fixes a regression introduced in 9d2e942.

Initial-fix-by: Pascal Obry <pascal.obry@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano
2010-06-23 10:27:39 -07:00
parent 9d2e942070
commit ce83eda155
1 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
url.c
View File

@ -67,12 +67,10 @@ static int url_decode_char(const char *q)
return val; return val;
} }
static char *url_decode_internal(const char **query, const char *stop_at) static char *url_decode_internal(const char **query, const char *stop_at, struct strbuf *out)
{ {
const char *q = *query; const char *q = *query;
struct strbuf out;
strbuf_init(&out, 16);
do { do {
unsigned char c = *q; unsigned char c = *q;
@ -86,33 +84,43 @@ static char *url_decode_internal(const char **query, const char *stop_at)
if (c == '%') { if (c == '%') {
int val = url_decode_char(q + 1); int val = url_decode_char(q + 1);
if (0 <= val) { if (0 <= val) {
strbuf_addch(&out, val); strbuf_addch(out, val);
q += 3; q += 3;
continue; continue;
} }
} }
if (c == '+') if (c == '+')
strbuf_addch(&out, ' '); strbuf_addch(out, ' ');
else else
strbuf_addch(&out, c); strbuf_addch(out, c);
q++; q++;
} while (1); } while (1);
*query = q; *query = q;
return strbuf_detach(&out, NULL); return strbuf_detach(out, NULL);
} }
char *url_decode(const char *url) char *url_decode(const char *url)
{ {
return url_decode_internal(&url, NULL); struct strbuf out = STRBUF_INIT;
const char *slash = strchr(url, '/');
/* Skip protocol part if present */
if (slash && url < slash) {
strbuf_add(&out, url, slash - url);
url = slash;
}
return url_decode_internal(&url, NULL, &out);
} }
char *url_decode_parameter_name(const char **query) char *url_decode_parameter_name(const char **query)
{ {
return url_decode_internal(query, "&="); struct strbuf out = STRBUF_INIT;
return url_decode_internal(query, "&=", &out);
} }
char *url_decode_parameter_value(const char **query) char *url_decode_parameter_value(const char **query)
{ {
return url_decode_internal(query, "&"); struct strbuf out = STRBUF_INIT;
return url_decode_internal(query, "&", &out);
} }