mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

format-patch: free rev.message_id when exiting

Browse Source 
We may allocate a message-id string via gen_message_id(), but we never
free it, causing a small leak. This can be demonstrated by running t9001
with a leak-checking build. The offending test is the one touched by
3ece9bf0f9 (send-email: clear the $message_id after validation,
2023-05-17), but the leak is much older than that. The test was simply
unlucky enough to trigger the leaking code path for the first time.

We can fix this by freeing the string at the end of the function. We can
also re-mark the test script as leak-free, effectively reverting
20bd08aefb (t9001: mark the script as no longer leak checker clean,
2023-05-17).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King
2023-05-18 20:03:25 -04:00
committed by Junio C Hamano
parent 20bd08aefb
commit cfa120947e
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
builtin/log.c
View File

@ -2415,6 +2415,7 @@ done:
strbuf_release(&rdiff_title); strbuf_release(&rdiff_title);
strbuf_release(&sprefix); strbuf_release(&sprefix);
free(to_free); free(to_free);
free(rev.message_id);
if (rev.ref_message_ids) if (rev.ref_message_ids)
string_list_clear(rev.ref_message_ids, 0); string_list_clear(rev.ref_message_ids, 0);
free(rev.ref_message_ids); free(rev.ref_message_ids);

2
t/t9001-send-email.sh
View File

@ -4,7 +4,7 @@ test_description='git send-email'
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
# no longer TEST_PASSES_SANITIZE_LEAK=true - format-patch --thread leaks TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh . ./test-lib.sh
# May be altered later in the test # May be altered later in the test