refs: keep track of unresolved reference value in iterators
Since ref iterators do not hold onto the direct value of a reference without resolving it, the only way to get ahold of a direct value of a symbolic ref is to make a separate call to refs_read_symbolic_ref. To make accessing the direct value of a symbolic ref more efficient, let's save the direct value of the ref in the iterators for both the files backend and the reftable backend. Signed-off-by: John Cai <johncai86@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
@ -34,6 +34,7 @@ struct ref_dir *get_ref_dir(struct ref_entry *entry)
|
||||
}
|
||||
|
||||
struct ref_entry *create_ref_entry(const char *refname,
|
||||
const char *referent,
|
||||
const struct object_id *oid, int flag)
|
||||
{
|
||||
struct ref_entry *ref;
|
||||
@ -41,6 +42,8 @@ struct ref_entry *create_ref_entry(const char *refname,
|
||||
FLEX_ALLOC_STR(ref, name, refname);
|
||||
oidcpy(&ref->u.value.oid, oid);
|
||||
ref->flag = flag;
|
||||
ref->u.value.referent = xstrdup_or_null(referent);
|
||||
|
||||
return ref;
|
||||
}
|
||||
|
||||
@ -66,6 +69,7 @@ static void free_ref_entry(struct ref_entry *entry)
|
||||
*/
|
||||
clear_ref_dir(&entry->u.subdir);
|
||||
}
|
||||
free(entry->u.value.referent);
|
||||
free(entry);
|
||||
}
|
||||
|
||||
@ -431,6 +435,7 @@ static int cache_ref_iterator_advance(struct ref_iterator *ref_iterator)
|
||||
level->index = -1;
|
||||
} else {
|
||||
iter->base.refname = entry->name;
|
||||
iter->base.referent = entry->u.value.referent;
|
||||
iter->base.oid = &entry->u.value.oid;
|
||||
iter->base.flags = entry->flag;
|
||||
return ITER_OK;
|
||||
|
Reference in New Issue
Block a user