mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

push: copy code to setup_push_simple()

Browse Source 
In order to avoid doing unnecessary things and simplify it in further
patches. In particular moving the additional name safety out of
setup_push_upstream() and into setup_push_simple() and thus making both
more straightforward.

The code is copied exactly as-is; no functional changes.

Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Felipe Contreras
2021-05-31 14:32:33 -05:00
committed by Junio C Hamano
parent 3b9fd8361f
commit d099b9c9c7
1 changed files with 32 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
builtin/push.c
View File

@ -225,10 +225,38 @@ static void setup_push_current(struct remote *remote, struct branch *branch)
static void setup_push_simple(struct remote *remote, struct branch *branch, int same_remote) static void setup_push_simple(struct remote *remote, struct branch *branch, int same_remote)
{ {
if (!same_remote) {
if (!branch)
die(_(message_detached_head_die), remote->name);
refspec_appendf(&rs, "%s:%s", branch->refname, branch->refname);
} else {
if (!branch)
die(_(message_detached_head_die), remote->name);
if (!branch->merge_nr || !branch->merge || !branch->remote_name)
die(_("The current branch %s has no upstream branch.\n"
"To push the current branch and set the remote as upstream, use\n"
"\n"
" git push --set-upstream %s %s\n"),
branch->name,
remote->name,
branch->name);
if (branch->merge_nr != 1)
die(_("The current branch %s has multiple upstream branches, "
"refusing to push."), branch->name);
if (!same_remote) if (!same_remote)
setup_push_current(remote, branch); die(_("You are pushing to remote '%s', which is not the upstream of\n"
else "your current branch '%s', without telling me what to push\n"
setup_push_upstream(remote, branch, same_remote, 1); "to update which remote branch."),
remote->name, branch->name);
if (1) {
/* Additional safety */
if (strcmp(branch->refname, branch->merge[0]->src))
die_push_simple(branch, remote);
}
refspec_appendf(&rs, "%s:%s", branch->refname, branch->merge[0]->src);
}
} }
static int is_same_remote(struct remote *remote) static int is_same_remote(struct remote *remote)