use a hashmap to make remotes faster

Remotes are stored as an array, so looking one up or adding one without
duplication is an O(n) operation.  Reading an entire config file full of
remotes is O(n^2) in the number of remotes.  For a repository with tens of
thousands of remotes, the running time can hit multiple minutes.

Hash tables are way faster.  So we add a hashmap from remote name to
struct remote and use it for all lookups.  The time to add a new remote to
a repo that already has 50,000 remotes drops from ~2 minutes to < 1
second.

We retain the old array of remotes so iterators proceed in config-file
order.

Signed-off-by: Patrick Reynolds <patrick.reynolds@github.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Reynolds
2014-07-29 14:43:39 +00:00
committed by Junio C Hamano
parent 583b61c1af
commit d0da003d5b
2 changed files with 49 additions and 17 deletions

View File

@ -2,6 +2,7 @@
#define REMOTE_H
#include "parse-options.h"
#include "hashmap.h"
enum {
REMOTE_CONFIG,
@ -10,6 +11,8 @@ enum {
};
struct remote {
struct hashmap_entry ent; /* must be first */
const char *name;
int origin;