run-command: introduce CHILD_PROCESS_INIT
Most struct child_process variables are cleared using memset first after declaration. Provide a macro, CHILD_PROCESS_INIT, that can be used to initialize them statically instead. That's shorter, doesn't require a function call and is slightly more readable (especially given that we already have STRBUF_INIT, ARGV_ARRAY_INIT etc.). Helped-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
6c4ab27f23
commit
d318027932
@ -3,7 +3,7 @@
|
||||
|
||||
int main(int argc, char **argv)
|
||||
{
|
||||
struct child_process cp;
|
||||
struct child_process cp = CHILD_PROCESS_INIT;
|
||||
int nogit = 0;
|
||||
|
||||
setup_git_directory_gently(&nogit);
|
||||
@ -13,7 +13,6 @@ int main(int argc, char **argv)
|
||||
setup_work_tree();
|
||||
argv++;
|
||||
}
|
||||
memset(&cp, 0, sizeof(cp));
|
||||
cp.git_cmd = 1;
|
||||
cp.argv = (const char **)argv + 1;
|
||||
return run_command(&cp);
|
||||
|
Reference in New Issue
Block a user