t/: Use "test_must_fail git" instead of "! git"
This patch changes every occurrence of "! git" -- with the meaning that a git call has to gracefully fail -- into "test_must_fail git". This is useful to - make sure the test does not fail because of a signal, e.g. SIGSEGV, and - advertise the use of "test_must_fail" for new tests. Signed-off-by: Stephan Beyer <s-beyer@gmx.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
5a26973025
commit
d492b31caf
@ -63,7 +63,7 @@ test_expect_success "$name" "
|
||||
git update-index --remove dir/file &&
|
||||
git update-index --add dir/file/file &&
|
||||
git commit -m '$name' &&
|
||||
! git-svn set-tree --find-copies-harder --rmdir \
|
||||
test_must_fail git-svn set-tree --find-copies-harder --rmdir \
|
||||
remotes/git-svn..mybranch" || true
|
||||
|
||||
|
||||
@ -77,7 +77,7 @@ test_expect_success "$name" '
|
||||
git update-index --remove -- bar/zzz &&
|
||||
git update-index --add -- bar &&
|
||||
git commit -m "$name" &&
|
||||
! git-svn set-tree --find-copies-harder --rmdir \
|
||||
test_must_fail git-svn set-tree --find-copies-harder --rmdir \
|
||||
remotes/git-svn..mybranch2' || true
|
||||
|
||||
|
||||
@ -91,7 +91,7 @@ test_expect_success "$name" '
|
||||
echo yyy > bar/zzz/yyy &&
|
||||
git update-index --add bar/zzz/yyy &&
|
||||
git commit -m "$name" &&
|
||||
! git-svn set-tree --find-copies-harder --rmdir \
|
||||
test_must_fail git-svn set-tree --find-copies-harder --rmdir \
|
||||
remotes/git-svn..mybranch3' || true
|
||||
|
||||
|
||||
@ -105,7 +105,7 @@ test_expect_success "$name" '
|
||||
echo asdf > dir &&
|
||||
git update-index --add -- dir &&
|
||||
git commit -m "$name" &&
|
||||
! git-svn set-tree --find-copies-harder --rmdir \
|
||||
test_must_fail git-svn set-tree --find-copies-harder --rmdir \
|
||||
remotes/git-svn..mybranch4' || true
|
||||
|
||||
|
||||
@ -216,7 +216,7 @@ test_expect_success "$name" "test_cmp a expected"
|
||||
test_expect_success 'exit if remote refs are ambigious' "
|
||||
git config --add svn-remote.svn.fetch \
|
||||
bar:refs/remotes/git-svn &&
|
||||
! git-svn migrate
|
||||
test_must_fail git-svn migrate
|
||||
"
|
||||
|
||||
test_expect_success 'exit if init-ing a would clobber a URL' '
|
||||
@ -224,7 +224,7 @@ test_expect_success 'exit if init-ing a would clobber a URL' '
|
||||
svn mkdir -m "mkdir bar" "${svnrepo}2/bar" &&
|
||||
git config --unset svn-remote.svn.fetch \
|
||||
"^bar:refs/remotes/git-svn$" &&
|
||||
! git-svn init "${svnrepo}2/bar"
|
||||
test_must_fail git-svn init "${svnrepo}2/bar"
|
||||
'
|
||||
|
||||
test_expect_success \
|
||||
|
||||
Reference in New Issue
Block a user