mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-remote-mediawiki: clearly rewrite double dereference

Browse Source 
@$var structures are re-written in the following way: @{$var}
It makes them more readable.

Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr>
Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Célestin Matte
2013-06-14 15:50:36 +02:00
committed by Junio C Hamano
parent 7c47583793
commit d49a038451
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
contrib/mw-to-git/git-remote-mediawiki.perl
View File

@ -237,7 +237,7 @@ sub get_mw_tracked_pages {
sub get_mw_page_list { sub get_mw_page_list {
my $page_list = shift; my $page_list = shift;
my $pages = shift; my $pages = shift;
my @some_pages = @$page_list; my @some_pages = @{$page_list};
while (@some_pages) { while (@some_pages) {
my $last_page = SLICE_SIZE; my $last_page = SLICE_SIZE;
if ($#some_pages < $last_page) { if ($#some_pages < $last_page) {
@ -881,7 +881,7 @@ sub mw_import_revids {
my $n_actual = 0; my $n_actual = 0;
my $last_timestamp = 0; # Placeholer in case $rev->timestamp is undefined my $last_timestamp = 0; # Placeholer in case $rev->timestamp is undefined
foreach my $pagerevid (@$revision_ids) { foreach my $pagerevid (@{$revision_ids}) {
# Count page even if we skip it, since we display # Count page even if we skip it, since we display
# $n/$total and $total includes skipped pages. # $n/$total and $total includes skipped pages.
$n++; $n++;
@ -916,7 +916,7 @@ sub mw_import_revids {
my $page_title = $result_page->{title}; my $page_title = $result_page->{title};
if (!exists($pages->{$page_title})) { if (!exists($pages->{$page_title})) {
print {*STDERR} "${n}/", scalar(@$revision_ids), print {*STDERR} "${n}/", scalar(@{$revision_ids}),
": Skipping revision #$rev->{revid} of ${page_title}\n"; ": Skipping revision #$rev->{revid} of ${page_title}\n";
next; next;
} }
@ -949,7 +949,7 @@ sub mw_import_revids {
# If this is a revision of the media page for new version # If this is a revision of the media page for new version
# of a file do one common commit for both file and media page. # of a file do one common commit for both file and media page.
# Else do commit only for that page. # Else do commit only for that page.
print {*STDERR} "${n}/", scalar(@$revision_ids), ": Revision #$rev->{revid} of $commit{title}\n"; print {*STDERR} "${n}/", scalar(@{$revision_ids}), ": Revision #$rev->{revid} of $commit{title}\n";
import_file_revision(\%commit, ($fetch_from == 1), $n_actual, \%mediafile); import_file_revision(\%commit, ($fetch_from == 1), $n_actual, \%mediafile);
} }