mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-filter-branch: avoid collisions with variables in eval'ed commands

Browse Source 
Avoid using simple variable names like 'i', since user commands are eval'ed
and may clash with and overwrite our values.

Signed-off-by: Elijah Newren <newren@gmail.com>
Acked-by: Petr Baudis <pasky@suse.cz>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Elijah Newren
2009-03-25 15:51:01 -06:00
committed by Junio C Hamano
parent 8befac5d6f
commit d5b0c97d13
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
git-filter-branch.sh
View File

@ -272,10 +272,10 @@ test $commits -eq 0 && die "Found nothing to rewrite"
# Rewrite the commits # Rewrite the commits
i=0 git_filter_branch__commit_count=0
while read commit parents; do while read commit parents; do
i=$(($i+1)) git_filter_branch__commit_count=$(($git_filter_branch__commit_count+1))
printf "\rRewrite $commit ($i/$commits)" printf "\rRewrite $commit ($git_filter_branch__commit_count/$commits)"
case "$filter_subdir" in case "$filter_subdir" in
"") "")