mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clean up and optimize nth_packed_object_sha1() usage

Browse Source 
Let's avoid the open coded pack index reference in pack-object and use
nth_packed_object_sha1() instead.  This will help encapsulating index
format differences in one place.

And while at it there is no reason to copy SHA1's over and over while a
direct pointer to it in the index will do just fine.

Signed-off-by: Nicolas Pitre <nico@cam.org>
Acked-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Nicolas Pitre
2007-04-04 16:49:04 -04:00
committed by Junio C Hamano
parent d5ad36fe35
commit d72308e01c
6 changed files with 24 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
builtin-fsck.c
View File

@ -348,7 +348,7 @@ static int fsck_tag(struct tag *tag)
return 0;
}
static int fsck_sha1(unsigned char *sha1)
static int fsck_sha1(const unsigned char *sha1)
{
struct object *obj = parse_object(sha1);
if (!obj) {
@ -648,11 +648,8 @@ int cmd_fsck(int argc, char **argv, const char *prefix)
for (p = packed_git; p; p = p->next) {
uint32_t i, num = num_packed_objects(p);
for (i = 0; i < num; i++) {
unsigned char sha1[20];
nth_packed_object_sha1(p, i, sha1);
fsck_sha1(sha1);
}
for (i = 0; i < num; i++)
fsck_sha1(nth_packed_object_sha1(p, i));
}
}