make struct progress an opaque type
This allows for better management of progress "object" existence, as well as making the progress display implementation more independent from its callers. Signed-off-by: Nicolas Pitre <nico@cam.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
0e54913796
commit
dc6a0757c4
@ -311,7 +311,7 @@ static void unpack_one(unsigned nr)
|
||||
static void unpack_all(void)
|
||||
{
|
||||
int i;
|
||||
struct progress progress;
|
||||
struct progress *progress = NULL;
|
||||
struct pack_header *hdr = fill(sizeof(struct pack_header));
|
||||
unsigned nr_objects = ntohl(hdr->hdr_entries);
|
||||
|
||||
@ -322,12 +322,12 @@ static void unpack_all(void)
|
||||
use(sizeof(struct pack_header));
|
||||
|
||||
if (!quiet)
|
||||
start_progress(&progress, "Unpacking objects", nr_objects);
|
||||
progress = start_progress("Unpacking objects", nr_objects);
|
||||
obj_list = xmalloc(nr_objects * sizeof(*obj_list));
|
||||
for (i = 0; i < nr_objects; i++) {
|
||||
unpack_one(i);
|
||||
if (!quiet)
|
||||
display_progress(&progress, i + 1);
|
||||
display_progress(progress, i + 1);
|
||||
}
|
||||
if (!quiet)
|
||||
stop_progress(&progress);
|
||||
|
||||
Reference in New Issue
Block a user