mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CodingGuidelines: once it is in, it is not worth the code churn

Browse Source 
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano
2014-04-30 14:23:26 -07:00
parent 7e76a2f975
commit dd30800bcd
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Documentation/CodingGuidelines
View File

@ -18,6 +18,14 @@ code. For Git in general, three rough rules are:
judgement call, the decision based more on real world judgement call, the decision based more on real world
constraints people face than what the paper standard says. constraints people face than what the paper standard says.
- Fixing style violations while working on a real change as a
preparatory clean-up step is good, but otherwise avoid useless code
churn for the sake of conforming to the style.
"Once it _is_ in the tree, it's not really worth the patch noise to
go and fix it up."
Cf. http://article.gmane.org/gmane.linux.kernel/943020
Make your code readable and sensible, and don't try to be clever. Make your code readable and sensible, and don't try to be clever.
As for more concrete guidelines, just imitate the existing code As for more concrete guidelines, just imitate the existing code