Merge branch 'es/check-non-portable-pre-5.10'
Developer support update. * es/check-non-portable-pre-5.10: check-non-portable-shell: support Perl versions older than 5.10
This commit is contained in:
@ -27,14 +27,14 @@ for my $i (@ARGV) {
|
|||||||
close $f;
|
close $f;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
my $line = '';
|
||||||
while (<>) {
|
while (<>) {
|
||||||
chomp;
|
chomp;
|
||||||
|
$line .= $_;
|
||||||
# stitch together incomplete lines (those ending with "\")
|
# stitch together incomplete lines (those ending with "\")
|
||||||
while (s/\\$//) {
|
next if $line =~ s/\\$//;
|
||||||
$_ .= readline;
|
|
||||||
chomp;
|
|
||||||
}
|
|
||||||
|
|
||||||
|
$_ = $line;
|
||||||
/\bcp\s+-a/ and err 'cp -a is not portable';
|
/\bcp\s+-a/ and err 'cp -a is not portable';
|
||||||
/\bsed\s+-[^efn]\s+/ and err 'sed option not portable (use only -n, -e, -f)';
|
/\bsed\s+-[^efn]\s+/ and err 'sed option not portable (use only -n, -e, -f)';
|
||||||
/\becho\s+-[neE]/ and err 'echo with option is not portable (use printf)';
|
/\becho\s+-[neE]/ and err 'echo with option is not portable (use printf)';
|
||||||
@ -48,6 +48,7 @@ while (<>) {
|
|||||||
/\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable (use FOO=bar && export FOO)';
|
/\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable (use FOO=bar && export FOO)';
|
||||||
/^\s*([A-Z0-9_]+=(\w+|(["']).*?\3)\s+)+(\w+)/ and exists($func{$4}) and
|
/^\s*([A-Z0-9_]+=(\w+|(["']).*?\3)\s+)+(\w+)/ and exists($func{$4}) and
|
||||||
err '"FOO=bar shell_func" assignment extends beyond "shell_func"';
|
err '"FOO=bar shell_func" assignment extends beyond "shell_func"';
|
||||||
|
$line = '';
|
||||||
# this resets our $. for each file
|
# this resets our $. for each file
|
||||||
close ARGV if eof;
|
close ARGV if eof;
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user