mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-send-email: die if sendmail.* config is set

Browse Source 
I've seen several people mis-configure git send-email on their first
attempt because they set the sendmail.* config options - not
sendemail.*. This patch detects this mistake and bails out with a
friendly warning.

Signed-off-by: Drew DeVault <sir@cmpwn.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Drew DeVault
2020-07-23 20:44:32 -04:00
committed by Junio C Hamano
parent 3d20111cbd
commit dd84e528a3
4 changed files with 68 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
perl/Git.pm
View File

@ -723,6 +723,32 @@ sub config_int {
return scalar _config_common({'kind' => '--int'}, @_);
}
=item config_regexp ( RE )
Retrieve the list of configuration key names matching the regular
expression C<RE>. The return value is a list of strings matching
this regex.
=cut
sub config_regexp {
my ($self, $regex) = _maybe_self(@_);
try {
my @cmd = ('config', '--name-only', '--get-regexp', $regex);
unshift @cmd, $self if $self;
my @matches = command(@cmd);
return @matches;
} catch Git::Error::Command with {
my $E = shift;
if ($E->value() == 1) {
my @matches = ();
return @matches;
} else {
throw $E;
}
};
}
# Common subroutine to implement bulk of what the config* family of methods
# do. This currently wraps command('config') so it is not so fast.
sub _config_common {