mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

replace and remove run_command_v_opt()

Browse Source 
Replace the remaining calls of run_command_v_opt() with run_command()
calls and explict struct child_process variables.  This is more verbose,
but not by much overall.  The code becomes more flexible, e.g. it's easy
to extend to conditionally add a new argument.

Then remove the now unused function and its own flag names, simplifying
the run-command API.

Suggested-by: Jeff King <peff@peff.net>
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
This commit is contained in:
René Scharfe
2022-10-30 12:55:06 +01:00
committed by Taylor Blau
parent ef249b398e
commit ddbb47fde9
13 changed files with 92 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
builtin/am.c
View File

@ -2187,11 +2187,12 @@ static int show_patch(struct am_state *state, enum show_patch_type sub_mode)
int len;
if (!is_null_oid(&state->orig_commit)) {
const char *av[] = {
"show", oid_to_hex(&state->orig_commit), "--", NULL
};
struct child_process cmd = CHILD_PROCESS_INIT;
return run_command_v_opt(av, RUN_GIT_CMD);
strvec_pushl(&cmd.args, "show", oid_to_hex(&state->orig_commit),
"--", NULL);
cmd.git_cmd = 1;
return run_command(&cmd);
}
switch (sub_mode) {