t1300: remove unreasonable expectation from TODO
In https://public-inbox.org/git/7vvc8alzat.fsf@alter.siamese.dyndns.org/ a reasonable patch was made quite a bit less so by changing a test case demonstrating a bug to a test case that demonstrates that we ask for too much: the test case 'unsetting the last key in a section removes header' now expects a future bug fix to be able to determine whether a free-form comment above a section header refers to said section or not. Rather than shooting for the stars (and not even getting off the ground), let's start shooting for something obtainable and be reasonably confident that we *can* get it. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
		 Johannes Schindelin
					Johannes Schindelin
				
			
				
					committed by
					
						 Junio C Hamano
						Junio C Hamano
					
				
			
			
				
	
			
			
			 Junio C Hamano
						Junio C Hamano
					
				
			
						parent
						
							85bf5d61e7
						
					
				
				
					commit
					dde154b5bd
				
			| @ -1390,7 +1390,7 @@ test_expect_success 'urlmatch with wildcard' ' | ||||
| ' | ||||
|  | ||||
| # good section hygiene | ||||
| test_expect_failure 'unsetting the last key in a section removes header' ' | ||||
| test_expect_failure '--unset last key removes section (except if commented)' ' | ||||
| 	cat >.git/config <<-\EOF && | ||||
| 	# some generic comment on the configuration file itself | ||||
| 	# a comment specific to this "section" section. | ||||
| @ -1404,6 +1404,25 @@ test_expect_failure 'unsetting the last key in a section removes header' ' | ||||
|  | ||||
| 	cat >expect <<-\EOF && | ||||
| 	# some generic comment on the configuration file itself | ||||
| 	# a comment specific to this "section" section. | ||||
| 	[section] | ||||
| 	# some intervening lines | ||||
| 	# that should also be dropped | ||||
|  | ||||
| 	# please be careful when you update the above variable | ||||
| 	EOF | ||||
|  | ||||
| 	git config --unset section.key && | ||||
| 	test_cmp expect .git/config && | ||||
|  | ||||
| 	cat >.git/config <<-\EOF && | ||||
| 	[section] | ||||
| 	key = value | ||||
| 	[next-section] | ||||
| 	EOF | ||||
|  | ||||
| 	cat >expect <<-\EOF && | ||||
| 	[next-section] | ||||
| 	EOF | ||||
|  | ||||
| 	git config --unset section.key && | ||||
|  | ||||
		Reference in New Issue
	
	Block a user