mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fetch--tool: fix uninitialized buffer when reading from stdin

Browse Source 
The original code allocates too much space and forgets to NUL
terminate the string.

Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Junio C Hamano
2007-02-26 11:37:43 -08:00
parent dcf01c6e6b
commit dec56c8cf1
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
builtin-fetch--tool.c
View File

@ -2,17 +2,24 @@
#include "refs.h" #include "refs.h"
#include "commit.h" #include "commit.h"
#define CHUNK_SIZE (1048576) #define CHUNK_SIZE 1024
static char *get_stdin(void) static char *get_stdin(void)
{ {
int offset = 0;
char *data = xmalloc(CHUNK_SIZE); char *data = xmalloc(CHUNK_SIZE);
int offset = 0, read = 0;
read = xread(0, data, CHUNK_SIZE); while (1) {
while (read == CHUNK_SIZE) { int cnt = xread(0, data + offset, CHUNK_SIZE);
offset += CHUNK_SIZE; if (cnt < 0)
die("error reading standard input: %s",
strerror(errno));
if (cnt == 0) {
data[offset] = 0;
break;
}
offset += cnt;
data = xrealloc(data, offset + CHUNK_SIZE); data = xrealloc(data, offset + CHUNK_SIZE);
read = xread(0, data + offset, CHUNK_SIZE);
} }
return data; return data;
} }