mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

list-objects-filter: don't memset after releasing filter struct

Browse Source 
If we see an error while parsing a "combine" filter, we call
list_objects_filter_release() to free any allocated memory,
and then use memset() to return the struct to a known state. But the
release function already does that reinitializing. Doing it again is
pointless.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King
2022-09-11 00:58:09 -04:00
committed by Junio C Hamano
parent 7522bb9bc9
commit e40d906449
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
list-objects-filter-options.c
View File

@ -187,10 +187,8 @@ static int parse_combine_filter(
cleanup: cleanup:
strbuf_list_free(subspecs); strbuf_list_free(subspecs);
if (result) { if (result)
list_objects_filter_release(filter_options); list_objects_filter_release(filter_options);
memset(filter_options, 0, sizeof(*filter_options));
}
return result; return result;
} }