mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

builtin/bundle.c: remove superfluous "newargc" variable

Browse Source 
As noted in 891cb09db6 (bundle: don't segfault on "git bundle
<subcmd>", 2022-12-20) the "newargc" in this function is redundant to
using our own "argc". Let's refactor the function to avoid needlessly
introducing another variable.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason
2022-12-27 19:39:09 +01:00
committed by Junio C Hamano
parent 891cb09db6
commit e778ecbcee
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
builtin/bundle.c
View File

@ -45,13 +45,12 @@ static int parse_options_cmd_bundle(int argc,
const char * const usagestr[], const char * const usagestr[],
const struct option options[], const struct option options[],
char **bundle_file) { char **bundle_file) {
int newargc; argc = parse_options(argc, argv, NULL, options, usagestr,
newargc = parse_options(argc, argv, NULL, options, usagestr,
PARSE_OPT_STOP_AT_NON_OPTION); PARSE_OPT_STOP_AT_NON_OPTION);
if (!newargc) if (!argc)
usage_with_options(usagestr, options); usage_with_options(usagestr, options);
*bundle_file = prefix_filename(prefix, argv[0]); *bundle_file = prefix_filename(prefix, argv[0]);
return newargc; return argc;
} }
static int cmd_bundle_create(int argc, const char **argv, const char *prefix) { static int cmd_bundle_create(int argc, const char **argv, const char *prefix) {