object API users + docs: check <0, not !0 with check_object_signature()
Change those users of the object API that misused check_object_signature() by assuming it returned any non-zero when the OID didn't match the expected value to check <0 instead. In practice all of this code worked before, but it wasn't consistent with rest of the users of the API. Let's also clarify what the <0 return value means in API docs. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:

committed by
Junio C Hamano

parent
cdcaaec9a6
commit
ee213de22d
@ -2613,7 +2613,7 @@ int read_loose_object(const char *path,
|
||||
}
|
||||
if (check_object_signature(the_repository, expected_oid,
|
||||
*contents, *size,
|
||||
oi->type_name->buf, real_oid))
|
||||
oi->type_name->buf, real_oid) < 0)
|
||||
goto out;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user