mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests: notice valgrind error in test_must_fail

Browse Source 
We tell valgrind to return 126 if it notices that something is wrong,
but we did not actually handle this in test_must_fail, leading to
false negatives.  Catch and report it.

Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Thomas Rast
2013-03-31 10:37:25 +02:00
committed by Junio C Hamano
parent 95d9d5ec75
commit eeb69131ed
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
t/test-lib-functions.sh
View File

@ -536,6 +536,9 @@ test_must_fail () {
elif test $exit_code = 127; then elif test $exit_code = 127; then
echo >&2 "test_must_fail: command not found: $*" echo >&2 "test_must_fail: command not found: $*"
return 1 return 1
elif test $exit_code = 126; then
echo >&2 "test_must_fail: valgrind error: $*"
return 1
fi fi
return 0 return 0
} }