use xstrncmpz()
Add and apply a semantic patch for calling xstrncmpz() to compare a NUL-terminated string with a buffer of a known length instead of using strncmp() and checking the terminating NUL explicitly. This simplifies callers by reducing code duplication. I had to adjust remote.c manually because Coccinelle inexplicably changed the indent of the else branches. Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
3526e67d91
commit
f0e578c69c
@ -96,8 +96,7 @@ static struct reflog_expire_cfg *find_cfg_ent(const char *pattern, size_t len)
|
||||
reflog_expire_cfg_tail = &reflog_expire_cfg;
|
||||
|
||||
for (ent = reflog_expire_cfg; ent; ent = ent->next)
|
||||
if (!strncmp(ent->pattern, pattern, len) &&
|
||||
ent->pattern[len] == '\0')
|
||||
if (!xstrncmpz(ent->pattern, pattern, len))
|
||||
return ent;
|
||||
|
||||
FLEX_ALLOC_MEM(ent, pattern, pattern, len);
|
||||
|
||||
Reference in New Issue
Block a user