mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

howto-index.sh: use the $( ... ) construct for command substitution

Browse Source 
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
   sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Elia Pinto
2014-04-16 10:29:45 -07:00
committed by Junio C Hamano
parent 75ee3d7078
commit f25f5e61a7
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Documentation/howto-index.sh
View File

@ -11,8 +11,8 @@ EOF
for txt for txt
do do
title=`expr "$txt" : '.*/\(.*\)\.txt$'` title=$(expr "$txt" : '.*/\(.*\)\.txt$')
from=`sed -ne ' from=$(sed -ne '
/^$/q /^$/q
/^From:[ ]/{ /^From:[ ]/{
s/// s///
@ -21,9 +21,9 @@ do
s/^/by / s/^/by /
p p
} }
' "$txt"` ' "$txt")
abstract=`sed -ne ' abstract=$(sed -ne '
/^Abstract:[ ]/{ /^Abstract:[ ]/{
s/^[^ ]*// s/^[^ ]*//
x x
@ -39,11 +39,11 @@ do
x x
p p
q q
}' "$txt"` }' "$txt")
if grep 'Content-type: text/asciidoc' >/dev/null $txt if grep 'Content-type: text/asciidoc' >/dev/null $txt
then then
file=`expr "$txt" : '\(.*\)\.txt$'`.html file=$(expr "$txt" : '\(.*\)\.txt$').html
else else
file="$txt" file="$txt"
fi fi