Convert struct object to object_id
struct object is one of the major data structures dealing with object IDs. Convert it to use struct object_id instead of an unsigned char array. Convert get_object_hash to refer to the new member as well. Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> Signed-off-by: Jeff King <peff@peff.net>
This commit is contained in:
committed by
Jeff King
parent
7999b2cf77
commit
f2fd0760f6
32
revision.c
32
revision.c
@ -86,7 +86,7 @@ void show_object_with_name(FILE *out, struct object *obj,
|
||||
leaf.elem = component;
|
||||
leaf.elem_len = strlen(component);
|
||||
|
||||
fprintf(out, "%s ", sha1_to_hex(obj->sha1));
|
||||
fprintf(out, "%s ", oid_to_hex(&obj->oid));
|
||||
show_path_truncated(out, &leaf);
|
||||
fputc('\n', out);
|
||||
}
|
||||
@ -106,10 +106,10 @@ static void mark_tree_contents_uninteresting(struct tree *tree)
|
||||
struct name_entry entry;
|
||||
struct object *obj = &tree->object;
|
||||
|
||||
if (!has_sha1_file(obj->sha1))
|
||||
if (!has_object_file(&obj->oid))
|
||||
return;
|
||||
if (parse_tree(tree) < 0)
|
||||
die("bad tree %s", sha1_to_hex(obj->sha1));
|
||||
die("bad tree %s", oid_to_hex(&obj->oid));
|
||||
|
||||
init_tree_desc(&desc, tree->buffer, tree->size);
|
||||
while (tree_entry(&desc, &entry)) {
|
||||
@ -164,7 +164,7 @@ void mark_parents_uninteresting(struct commit *commit)
|
||||
* it is popped next time around, we won't be trying
|
||||
* to parse it and get an error.
|
||||
*/
|
||||
if (!has_sha1_file(commit->object.sha1))
|
||||
if (!has_object_file(&commit->object.oid))
|
||||
commit->object.parsed = 1;
|
||||
|
||||
if (commit->object.flags & UNINTERESTING)
|
||||
@ -286,7 +286,7 @@ static struct commit *handle_commit(struct rev_info *revs,
|
||||
if (!object) {
|
||||
if (flags & UNINTERESTING)
|
||||
return NULL;
|
||||
die("bad object %s", sha1_to_hex(tag->tagged->sha1));
|
||||
die("bad object %s", oid_to_hex(&tag->tagged->oid));
|
||||
}
|
||||
object->flags |= flags;
|
||||
/*
|
||||
@ -610,7 +610,7 @@ static unsigned update_treesame(struct rev_info *revs, struct commit *commit)
|
||||
|
||||
st = lookup_decoration(&revs->treesame, &commit->object);
|
||||
if (!st)
|
||||
die("update_treesame %s", sha1_to_hex(commit->object.sha1));
|
||||
die("update_treesame %s", oid_to_hex(&commit->object.oid));
|
||||
relevant_parents = 0;
|
||||
relevant_change = irrelevant_change = 0;
|
||||
for (p = commit->parents, n = 0; p; n++, p = p->next) {
|
||||
@ -708,8 +708,8 @@ static void try_to_simplify_commit(struct rev_info *revs, struct commit *commit)
|
||||
}
|
||||
if (parse_commit(p) < 0)
|
||||
die("cannot simplify commit %s (because of %s)",
|
||||
sha1_to_hex(commit->object.sha1),
|
||||
sha1_to_hex(p->object.sha1));
|
||||
oid_to_hex(&commit->object.oid),
|
||||
oid_to_hex(&p->object.oid));
|
||||
switch (rev_compare_tree(revs, p, commit)) {
|
||||
case REV_TREE_SAME:
|
||||
if (!revs->simplify_history || !relevant_commit(p)) {
|
||||
@ -741,8 +741,8 @@ static void try_to_simplify_commit(struct rev_info *revs, struct commit *commit)
|
||||
*/
|
||||
if (parse_commit(p) < 0)
|
||||
die("cannot simplify commit %s (invalid %s)",
|
||||
sha1_to_hex(commit->object.sha1),
|
||||
sha1_to_hex(p->object.sha1));
|
||||
oid_to_hex(&commit->object.oid),
|
||||
oid_to_hex(&p->object.oid));
|
||||
p->parents = NULL;
|
||||
}
|
||||
/* fallthrough */
|
||||
@ -754,7 +754,7 @@ static void try_to_simplify_commit(struct rev_info *revs, struct commit *commit)
|
||||
irrelevant_change = 1;
|
||||
continue;
|
||||
}
|
||||
die("bad tree compare for commit %s", sha1_to_hex(commit->object.sha1));
|
||||
die("bad tree compare for commit %s", oid_to_hex(&commit->object.oid));
|
||||
}
|
||||
|
||||
/*
|
||||
@ -1189,7 +1189,7 @@ static void add_rev_cmdline_list(struct rev_info *revs,
|
||||
{
|
||||
while (commit_list) {
|
||||
struct object *object = &commit_list->item->object;
|
||||
add_rev_cmdline(revs, object, sha1_to_hex(object->sha1),
|
||||
add_rev_cmdline(revs, object, oid_to_hex(&object->oid),
|
||||
whence, flags);
|
||||
commit_list = commit_list->next;
|
||||
}
|
||||
@ -1435,7 +1435,7 @@ static void add_pending_commit_list(struct rev_info *revs,
|
||||
while (commit_list) {
|
||||
struct object *object = &commit_list->item->object;
|
||||
object->flags |= flags;
|
||||
add_pending_object(revs, object, sha1_to_hex(object->sha1));
|
||||
add_pending_object(revs, object, oid_to_hex(&object->oid));
|
||||
commit_list = commit_list->next;
|
||||
}
|
||||
}
|
||||
@ -3094,7 +3094,7 @@ static void track_linear(struct rev_info *revs, struct commit *commit)
|
||||
struct commit_list *p;
|
||||
for (p = revs->previous_parents; p; p = p->next)
|
||||
if (p->item == NULL || /* first commit */
|
||||
!hashcmp(p->item->object.sha1, commit->object.sha1))
|
||||
!oidcmp(&p->item->object.oid, &commit->object.oid))
|
||||
break;
|
||||
revs->linear = p != NULL;
|
||||
}
|
||||
@ -3132,7 +3132,7 @@ static struct commit *get_revision_1(struct rev_info *revs)
|
||||
if (add_parents_to_list(revs, commit, &revs->commits, NULL) < 0) {
|
||||
if (!revs->ignore_missing_links)
|
||||
die("Failed to traverse parents of commit %s",
|
||||
sha1_to_hex(commit->object.sha1));
|
||||
oid_to_hex(&commit->object.oid));
|
||||
}
|
||||
}
|
||||
|
||||
@ -3141,7 +3141,7 @@ static struct commit *get_revision_1(struct rev_info *revs)
|
||||
continue;
|
||||
case commit_error:
|
||||
die("Failed to simplify parents of commit %s",
|
||||
sha1_to_hex(commit->object.sha1));
|
||||
oid_to_hex(&commit->object.oid));
|
||||
default:
|
||||
if (revs->track_linear)
|
||||
track_linear(revs, commit);
|
||||
|
||||
Reference in New Issue
Block a user