mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

parse-options: avoid magic return codes

Browse Source 
Give names to these magic negative numbers. Make parse_opt_ll_cb
return an enum to make clear it can actually control parse_options()
with different return values (parse_opt_cb can too, but nobody needs
it).

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Nguyễn Thái Ngọc Duy
2019-01-27 07:35:27 +07:00
committed by Junio C Hamano
parent bf3ff338a2
commit f41179f16b
5 changed files with 68 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
parse-options-cb.c
View File

@ -170,10 +170,10 @@ int parse_opt_noop_cb(const struct option *opt, const char *arg, int unset)
* "-h" output even if it's not being handled directly by
* parse_options().
*/
int parse_opt_unknown_cb(struct parse_opt_ctx_t *ctx,
const struct option *opt, int unset)
enum parse_opt_result parse_opt_unknown_cb(struct parse_opt_ctx_t *ctx,
const struct option *opt, int unset)
{
return -2;
return PARSE_OPT_UNKNOWN;
}
/**