mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

__attribute__: remove redundant attribute declaration for git_die_config()

Browse Source 
The convention is to declare the function attribute to an extern
function together with its declaration in the header file, without
repeating the attribute declaration with its definition in the .c
source file (a file-scope static function declares its attribute
together with its definition in the .c file it is defined, as there
is no other place to do so).

The definition of git_die_config() in config.c did not follow the
convention and had its attribute declared with both its declaration
in the header and its definition in the .c source file.

Remove the one in the config.c to match everybody else.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano
2024-06-08 11:37:45 -07:00
parent 89e78c7cda
commit f52c9a2a28
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
config.c
View File

@ -2822,7 +2822,6 @@ void git_die_config_linenr(const char *key, const char *filename, int linenr)
key, filename, linenr); key, filename, linenr);
} }
NORETURN __attribute__((format(printf, 2, 3)))
void git_die_config(const char *key, const char *err, ...) void git_die_config(const char *key, const char *err, ...)
{ {
const struct string_list *values; const struct string_list *values;