mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix tests breaking when checkout path contains shell metacharacters

Browse Source 
This fixes the remainder of the issues where the test script itself is at
fault for failing when the git checkout path contains whitespace or other
shell metacharacters.

The majority of git svn tests used the idiom

  test_expect_success "title" "test script using $svnrepo"

These were changed to have the test script in single-quotes:

  test_expect_success "title" 'test script using "$svnrepo"'

which unfortunately makes the patch appear larger than it really is.

One consequence of this change is that in the verbose test output the
value of $svnrepo (and in some cases other variables, too) is no
longer expanded, i.e. previously we saw

  * expecting success:
	test script using /path/to/git/t/trash/svnrepo

but now it is:

  * expecting success:
	test script using "$svnrepo"

Signed-off-by: Bryan Donlan <bdonlan@fushizen.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Bryan Donlan
2008-05-04 01:37:59 -04:00
committed by Junio C Hamano
parent 0e46e70462
commit f69e836fab
39 changed files with 475 additions and 469 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
t/t9103-git-svn-tracked-directory-removed.sh
View File

@ -10,30 +10,30 @@ test_expect_success 'make history for tracking' '
mkdir import &&
mkdir import/trunk &&
echo hello >> import/trunk/README &&
svn import -m initial import $svnrepo &&
svn import -m initial import "$svnrepo" &&
rm -rf import &&
svn co $svnrepo/trunk trunk &&
svn co "$svnrepo"/trunk trunk &&
echo bye bye >> trunk/README &&
svn rm -m "gone" $svnrepo/trunk &&
svn rm -m "gone" "$svnrepo"/trunk &&
rm -rf trunk &&
mkdir trunk &&
echo "new" > trunk/FOLLOWME &&
svn import -m "new trunk" trunk $svnrepo/trunk
svn import -m "new trunk" trunk "$svnrepo"/trunk
'
test_expect_success 'clone repo with git' '
git svn clone -s $svnrepo x &&
git svn clone -s "$svnrepo" x &&
test -f x/FOLLOWME &&
test ! -f x/README
'
test_expect_success 'make sure r2 still has old file' '
test_expect_success 'make sure r2 still has old file' "
cd x &&
test -n "$(git svn find-rev r1)" &&
git reset --hard $(git svn find-rev r1) &&
test -n \"\$(git svn find-rev r1)\" &&
git reset --hard \$(git svn find-rev r1) &&
test -f README &&
test ! -f FOLLOWME &&
test x$(git svn find-rev r2) = x
'
test x\$(git svn find-rev r2) = x
"
test_done