Fix tests breaking when checkout path contains shell metacharacters
This fixes the remainder of the issues where the test script itself is at fault for failing when the git checkout path contains whitespace or other shell metacharacters. The majority of git svn tests used the idiom test_expect_success "title" "test script using $svnrepo" These were changed to have the test script in single-quotes: test_expect_success "title" 'test script using "$svnrepo"' which unfortunately makes the patch appear larger than it really is. One consequence of this change is that in the verbose test output the value of $svnrepo (and in some cases other variables, too) is no longer expanded, i.e. previously we saw * expecting success: test script using /path/to/git/t/trash/svnrepo but now it is: * expecting success: test script using "$svnrepo" Signed-off-by: Bryan Donlan <bdonlan@fushizen.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
0e46e70462
commit
f69e836fab
@ -6,17 +6,17 @@
|
||||
test_description='git-svn log tests'
|
||||
. ./lib-git-svn.sh
|
||||
|
||||
test_expect_success 'setup repository and import' "
|
||||
test_expect_success 'setup repository and import' '
|
||||
mkdir import &&
|
||||
cd import &&
|
||||
for i in trunk branches/a branches/b \
|
||||
tags/0.1 tags/0.2 tags/0.3; do
|
||||
mkdir -p \$i && \
|
||||
echo hello >> \$i/README || exit 1
|
||||
mkdir -p $i && \
|
||||
echo hello >> $i/README || exit 1
|
||||
done && \
|
||||
svn import -m test . $svnrepo
|
||||
svn import -m test . "$svnrepo"
|
||||
cd .. &&
|
||||
git-svn init $svnrepo -T trunk -b branches -t tags &&
|
||||
git-svn init "$svnrepo" -T trunk -b branches -t tags &&
|
||||
git-svn fetch &&
|
||||
git reset --hard trunk &&
|
||||
echo bye >> README &&
|
||||
@ -37,7 +37,7 @@ test_expect_success 'setup repository and import' "
|
||||
echo try >> README &&
|
||||
git commit -a -m try &&
|
||||
git svn dcommit
|
||||
"
|
||||
'
|
||||
|
||||
test_expect_success 'run log' "
|
||||
git reset --hard a &&
|
||||
|
||||
Reference in New Issue
Block a user