mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

config: fix --comment formatting

Browse Source 
When git adds comments itself (like "rebase -i" todo list and
"commit -e" log message editor), it always gives a comment
introducer "#" followed by a Space before the message, except for
the recently introduced "git config --comment", where the users are
forced to say " this is my comment" if they want to add their
comment in this usual format; otherwise their comment string will
end up without a space after the "#".

Make it more ergonomic, while keeping it possible to also use this
unusual style, by massaging the comment string at the UI layer with
a set of simple rules:

 * If the given comment string begins with '#', it is passed intact.
 * Otherwise, "# " is prefixed.
 * A string with LF in it cannot be used as a comment string.

Right now there is only one "front-end" that accepts end-user
comment string and calls the underlying machinery to add or modify
configuration file with comments, but to make sure that the future
callers perform similar massaging as they see fit, add a sanity
check logic in git_config_set_multivar_in_file_gently(), which is
the single choke point in the codepaths that consumes the comment
string.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano
2024-03-15 12:43:58 -07:00
parent 42d5c03394
commit fbad334db9
4 changed files with 38 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
config.c
View File

@ -3043,12 +3043,9 @@ static ssize_t write_pair(int fd, const char *key, const char *value,
break;
}
if (comment) {
if (strchr(comment, '\n'))
die(_("multi-line comments are not permitted: '%s'"), comment);
else
strbuf_addf(&sb, "%s #%s\n", quote, comment);
} else
if (comment)
strbuf_addf(&sb, "%s %s\n", quote, comment);
else
strbuf_addf(&sb, "%s\n", quote);
ret = write_in_full(fd, sb.buf, sb.len);
@ -3214,6 +3211,17 @@ int git_config_set_multivar_in_file_gently(const char *config_filename,
size_t contents_sz;
struct config_store_data store = CONFIG_STORE_INIT;
if (comment) {
/*
* The front-end must have massaged the comment string
* properly before calling us.
*/
if (strchr(comment, '\n'))
BUG("multi-line comments are not permitted: '%s'", comment);
if (comment[0] != '#')
BUG("comment should begin with '#': '%s'", comment);
}
/* parse-key returns negative; flip the sign to feed exit(3) */
ret = 0 - git_config_parse_key(key, &store.key, &store.baselen);
if (ret)