Change the tests that skipped due to unavailable SYMLINKS support to
use the three-arg prereq form of test_expect_success.
This is like the "tests: implicitly skip SYMLINKS tests using
<prereq>" change, but I needed to create an additional test for some
setup code. It's in a separate change as suggested by Jonathan Nieder
for ease of reviewing.
    Date: Tue, 27 Jul 2010 16:17:37 -0500
    From: Jonathan Nieder <jrnieder@gmail.com>
    Message-ID: <20100727211737.GA11768@burratino>
    In-Reply-To: <1280265254-19642-2-git-send-email-avarab@gmail.com>
    Subject: Re: [PATCH 1/4] tests: implicitly skip SYMLINKS tests using <prereq>
    Ævar Arnfjörð Bjarmason wrote:
    > +++ b/t/t4004-diff-rename-symlink.sh
    > @@ -40,8 +34,9 @@ test_expect_success \
    >  # rezrov and nitfol are rename/copy of frotz and bozbar should be
    >  # a new creation.
    >
    > -GIT_DIFF_OPTS=--unified=0 git diff-index -M -p $tree >current
    > -cat >expected <<\EOF
    > +test_expect_success SYMLINKS 'setup diff output' "
    > +    GIT_DIFF_OPTS=--unified=0 git diff-index -M -p $tree >current
    > +    cat >expected <<\EOF
    >  diff --git a/bozbar b/bozbar
    >  new file mode 120000
    >  --- /dev/null
    Probably belongs in a separate patch.  More importantly, it is missing
    &&-chaining (not a regression, but it is best to set a good example).
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
	
		
			
				
	
	
		
			70 lines
		
	
	
		
			1.6 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			70 lines
		
	
	
		
			1.6 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
#!/bin/sh
 | 
						|
#
 | 
						|
# Copyright (c) 2005 Junio C Hamano
 | 
						|
#
 | 
						|
 | 
						|
test_description='More rename detection tests.
 | 
						|
 | 
						|
The rename detection logic should be able to detect pure rename or
 | 
						|
copy of symbolic links, but should not produce rename/copy followed
 | 
						|
by an edit for them.
 | 
						|
'
 | 
						|
. ./test-lib.sh
 | 
						|
. "$TEST_DIRECTORY"/diff-lib.sh
 | 
						|
 | 
						|
test_expect_success SYMLINKS \
 | 
						|
    'prepare reference tree' \
 | 
						|
    'echo xyzzy | tr -d '\\\\'012 >yomin &&
 | 
						|
     ln -s xyzzy frotz &&
 | 
						|
    git update-index --add frotz yomin &&
 | 
						|
    tree=$(git write-tree) &&
 | 
						|
    echo $tree'
 | 
						|
 | 
						|
test_expect_success SYMLINKS \
 | 
						|
    'prepare work tree' \
 | 
						|
    'mv frotz rezrov &&
 | 
						|
     rm -f yomin &&
 | 
						|
     ln -s xyzzy nitfol &&
 | 
						|
     ln -s xzzzy bozbar &&
 | 
						|
    git update-index --add --remove frotz rezrov nitfol bozbar yomin'
 | 
						|
 | 
						|
# tree has frotz pointing at xyzzy, and yomin that contains xyzzy to
 | 
						|
# confuse things.  work tree has rezrov (xyzzy) nitfol (xyzzy) and
 | 
						|
# bozbar (xzzzy).
 | 
						|
# rezrov and nitfol are rename/copy of frotz and bozbar should be
 | 
						|
# a new creation.
 | 
						|
 | 
						|
test_expect_success SYMLINKS 'setup diff output' "
 | 
						|
    GIT_DIFF_OPTS=--unified=0 git diff-index -M -p $tree >current &&
 | 
						|
    cat >expected <<\EOF
 | 
						|
diff --git a/bozbar b/bozbar
 | 
						|
new file mode 120000
 | 
						|
--- /dev/null
 | 
						|
+++ b/bozbar
 | 
						|
@@ -0,0 +1 @@
 | 
						|
+xzzzy
 | 
						|
\ No newline at end of file
 | 
						|
diff --git a/frotz b/nitfol
 | 
						|
similarity index 100%
 | 
						|
copy from frotz
 | 
						|
copy to nitfol
 | 
						|
diff --git a/frotz b/rezrov
 | 
						|
similarity index 100%
 | 
						|
rename from frotz
 | 
						|
rename to rezrov
 | 
						|
diff --git a/yomin b/yomin
 | 
						|
deleted file mode 100644
 | 
						|
--- a/yomin
 | 
						|
+++ /dev/null
 | 
						|
@@ -1 +0,0 @@
 | 
						|
-xyzzy
 | 
						|
\ No newline at end of file
 | 
						|
EOF
 | 
						|
"
 | 
						|
 | 
						|
test_expect_success SYMLINKS \
 | 
						|
    'validate diff output' \
 | 
						|
    'compare_diff_patch current expected'
 | 
						|
 | 
						|
test_done
 |