Change a pattern of hardcoding an "argv" array size, populating it and assigning to the "argv" member of "struct child_process" to instead use "strvec_push()" to add data to the "args" member. As noted in the preceding commit this moves us further towards being able to remove the "argv" member in a subsequent commit These callers could have used strvec_pushl(), but moving to strvec_push() makes the diff easier to read, and keeps the arguments aligned as before. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
			
				
	
	
		
			86 lines
		
	
	
		
			1.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			86 lines
		
	
	
		
			1.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
#include "cache.h"
 | 
						|
#include "config.h"
 | 
						|
#include "run-command.h"
 | 
						|
#include "strbuf.h"
 | 
						|
#include "prompt.h"
 | 
						|
#include "compat/terminal.h"
 | 
						|
 | 
						|
static char *do_askpass(const char *cmd, const char *prompt)
 | 
						|
{
 | 
						|
	struct child_process pass = CHILD_PROCESS_INIT;
 | 
						|
	static struct strbuf buffer = STRBUF_INIT;
 | 
						|
	int err = 0;
 | 
						|
 | 
						|
	strvec_push(&pass.args, cmd);
 | 
						|
	strvec_push(&pass.args, prompt);
 | 
						|
 | 
						|
	pass.out = -1;
 | 
						|
 | 
						|
	if (start_command(&pass))
 | 
						|
		return NULL;
 | 
						|
 | 
						|
	strbuf_reset(&buffer);
 | 
						|
	if (strbuf_read(&buffer, pass.out, 20) < 0)
 | 
						|
		err = 1;
 | 
						|
 | 
						|
	close(pass.out);
 | 
						|
 | 
						|
	if (finish_command(&pass))
 | 
						|
		err = 1;
 | 
						|
 | 
						|
	if (err) {
 | 
						|
		error("unable to read askpass response from '%s'", cmd);
 | 
						|
		strbuf_release(&buffer);
 | 
						|
		return NULL;
 | 
						|
	}
 | 
						|
 | 
						|
	strbuf_setlen(&buffer, strcspn(buffer.buf, "\r\n"));
 | 
						|
 | 
						|
	return buffer.buf;
 | 
						|
}
 | 
						|
 | 
						|
char *git_prompt(const char *prompt, int flags)
 | 
						|
{
 | 
						|
	char *r = NULL;
 | 
						|
 | 
						|
	if (flags & PROMPT_ASKPASS) {
 | 
						|
		const char *askpass;
 | 
						|
 | 
						|
		askpass = getenv("GIT_ASKPASS");
 | 
						|
		if (!askpass)
 | 
						|
			askpass = askpass_program;
 | 
						|
		if (!askpass)
 | 
						|
			askpass = getenv("SSH_ASKPASS");
 | 
						|
		if (askpass && *askpass)
 | 
						|
			r = do_askpass(askpass, prompt);
 | 
						|
	}
 | 
						|
 | 
						|
	if (!r) {
 | 
						|
		const char *err;
 | 
						|
 | 
						|
		if (git_env_bool("GIT_TERMINAL_PROMPT", 1)) {
 | 
						|
			r = git_terminal_prompt(prompt, flags & PROMPT_ECHO);
 | 
						|
			err = strerror(errno);
 | 
						|
		} else {
 | 
						|
			err = "terminal prompts disabled";
 | 
						|
		}
 | 
						|
		if (!r) {
 | 
						|
			/* prompts already contain ": " at the end */
 | 
						|
			die("could not read %s%s", prompt, err);
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return r;
 | 
						|
}
 | 
						|
 | 
						|
int git_read_line_interactively(struct strbuf *line)
 | 
						|
{
 | 
						|
	int ret;
 | 
						|
 | 
						|
	fflush(stdout);
 | 
						|
	ret = strbuf_getline_lf(line, stdin);
 | 
						|
	if (ret != EOF)
 | 
						|
		strbuf_trim_trailing_newline(line);
 | 
						|
 | 
						|
	return ret;
 | 
						|
}
 |