There has been a push to remove extern from function declarations.
Remove some instances of "extern" for function declarations which are
caught by Coccinelle. Note that Coccinelle has some difficulty with
processing functions with `__attribute__` or varargs so some `extern`
declarations are left behind to be dealt with in a future patch.
This was the Coccinelle patch used:
	@@
	type T;
	identifier f;
	@@
	- extern
	  T f(...);
and it was run with:
	$ git ls-files \*.{c,h} |
		grep -v ^compat/ |
		xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place
Files under `compat/` are intentionally excluded as some are directly
copied from external sources and we should avoid churning them as much
as possible.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
	
		
			
				
	
	
		
			47 lines
		
	
	
		
			1.0 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			47 lines
		
	
	
		
			1.0 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
#ifndef MAILINFO_H
 | 
						|
#define MAILINFO_H
 | 
						|
 | 
						|
#include "strbuf.h"
 | 
						|
 | 
						|
#define MAX_BOUNDARIES 5
 | 
						|
 | 
						|
struct mailinfo {
 | 
						|
	FILE *input;
 | 
						|
	FILE *output;
 | 
						|
	FILE *patchfile;
 | 
						|
 | 
						|
	struct strbuf name;
 | 
						|
	struct strbuf email;
 | 
						|
	int keep_subject;
 | 
						|
	int keep_non_patch_brackets_in_subject;
 | 
						|
	int add_message_id;
 | 
						|
	int use_scissors;
 | 
						|
	int use_inbody_headers;
 | 
						|
	const char *metainfo_charset;
 | 
						|
 | 
						|
	struct strbuf *content[MAX_BOUNDARIES];
 | 
						|
	struct strbuf **content_top;
 | 
						|
	struct strbuf charset;
 | 
						|
	unsigned int format_flowed:1;
 | 
						|
	unsigned int delsp:1;
 | 
						|
	char *message_id;
 | 
						|
	enum  {
 | 
						|
		TE_DONTCARE, TE_QP, TE_BASE64
 | 
						|
	} transfer_encoding;
 | 
						|
	int patch_lines;
 | 
						|
	int filter_stage; /* still reading log or are we copying patch? */
 | 
						|
	int header_stage; /* still checking in-body headers? */
 | 
						|
	struct strbuf inbody_header_accum;
 | 
						|
	struct strbuf **p_hdr_data;
 | 
						|
	struct strbuf **s_hdr_data;
 | 
						|
 | 
						|
	struct strbuf log_message;
 | 
						|
	int input_error;
 | 
						|
};
 | 
						|
 | 
						|
void setup_mailinfo(struct mailinfo *);
 | 
						|
int mailinfo(struct mailinfo *, const char *msg, const char *patch);
 | 
						|
void clear_mailinfo(struct mailinfo *);
 | 
						|
 | 
						|
#endif /* MAILINFO_H */
 |