The vast majority of files including object-store.h did not need dir.h
nor khash.h.  Split the header into two files, and let most just depend
upon object-store-ll.h, while letting the two callers that need it
depend on the full object-store.h.
After this patch:
    $ git grep -h include..object-store | sort | uniq -c
          2 #include "object-store.h"
        129 #include "object-store-ll.h"
Diff best viewed with `--color-moved`.
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
	
		
			
				
	
	
		
			84 lines
		
	
	
		
			2.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			84 lines
		
	
	
		
			2.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Builtin "git commit-commit"
 | 
						|
 *
 | 
						|
 * Copyright (c) 2014 Michael J Gruber <git@drmicha.warpmail.net>
 | 
						|
 *
 | 
						|
 * Based on git-verify-tag
 | 
						|
 */
 | 
						|
#include "builtin.h"
 | 
						|
#include "config.h"
 | 
						|
#include "gettext.h"
 | 
						|
#include "object-name.h"
 | 
						|
#include "object-store-ll.h"
 | 
						|
#include "repository.h"
 | 
						|
#include "commit.h"
 | 
						|
#include "run-command.h"
 | 
						|
#include "parse-options.h"
 | 
						|
#include "gpg-interface.h"
 | 
						|
 | 
						|
static const char * const verify_commit_usage[] = {
 | 
						|
		N_("git verify-commit [-v | --verbose] [--raw] <commit>..."),
 | 
						|
		NULL
 | 
						|
};
 | 
						|
 | 
						|
static int run_gpg_verify(struct commit *commit, unsigned flags)
 | 
						|
{
 | 
						|
	struct signature_check signature_check;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	memset(&signature_check, 0, sizeof(signature_check));
 | 
						|
 | 
						|
	ret = check_commit_signature(commit, &signature_check);
 | 
						|
	print_signature_buffer(&signature_check, flags);
 | 
						|
 | 
						|
	signature_check_clear(&signature_check);
 | 
						|
	return ret;
 | 
						|
}
 | 
						|
 | 
						|
static int verify_commit(const char *name, unsigned flags)
 | 
						|
{
 | 
						|
	struct object_id oid;
 | 
						|
	struct object *obj;
 | 
						|
 | 
						|
	if (repo_get_oid(the_repository, name, &oid))
 | 
						|
		return error("commit '%s' not found.", name);
 | 
						|
 | 
						|
	obj = parse_object(the_repository, &oid);
 | 
						|
	if (!obj)
 | 
						|
		return error("%s: unable to read file.", name);
 | 
						|
	if (obj->type != OBJ_COMMIT)
 | 
						|
		return error("%s: cannot verify a non-commit object of type %s.",
 | 
						|
				name, type_name(obj->type));
 | 
						|
 | 
						|
	return run_gpg_verify((struct commit *)obj, flags);
 | 
						|
}
 | 
						|
 | 
						|
int cmd_verify_commit(int argc, const char **argv, const char *prefix)
 | 
						|
{
 | 
						|
	int i = 1, verbose = 0, had_error = 0;
 | 
						|
	unsigned flags = 0;
 | 
						|
	const struct option verify_commit_options[] = {
 | 
						|
		OPT__VERBOSE(&verbose, N_("print commit contents")),
 | 
						|
		OPT_BIT(0, "raw", &flags, N_("print raw gpg status output"), GPG_VERIFY_RAW),
 | 
						|
		OPT_END()
 | 
						|
	};
 | 
						|
 | 
						|
	git_config(git_default_config, NULL);
 | 
						|
 | 
						|
	argc = parse_options(argc, argv, prefix, verify_commit_options,
 | 
						|
			     verify_commit_usage, PARSE_OPT_KEEP_ARGV0);
 | 
						|
	if (argc <= i)
 | 
						|
		usage_with_options(verify_commit_usage, verify_commit_options);
 | 
						|
 | 
						|
	if (verbose)
 | 
						|
		flags |= GPG_VERIFY_VERBOSE;
 | 
						|
 | 
						|
	/* sometimes the program was terminated because this signal
 | 
						|
	 * was received in the process of writing the gpg input: */
 | 
						|
	signal(SIGPIPE, SIG_IGN);
 | 
						|
	while (i < argc)
 | 
						|
		if (verify_commit(argv[i++], flags))
 | 
						|
			had_error = 1;
 | 
						|
	return had_error;
 | 
						|
}
 |