In the olden days,
    log --author=me --committer=him --grep=this --grep=that
used to be turned into:
    (OR (HEADER-AUTHOR me)
        (HEADER-COMMITTER him)
        (PATTERN this)
        (PATTERN that))
showing my patches that do not have any "this" nor "that", which was
totally useless.
80235ba ("log --author=me --grep=it" should find intersection, not union,
2010-01-17) improved it greatly to turn the same into:
    (ALL-MATCH
      (HEADER-AUTHOR me)
      (HEADER-COMMITTER him)
      (OR (PATTERN this) (PATTERN that)))
That is, "show only patches by me and committed by him, that have either
this or that", which is a lot more natural thing to ask.
We however need to be a bit more clever when the user asks more than one
"author" (or "committer"); because a commit has only one author (and one
committer), they ought to be interpreted as asking for union to be useful.
The current implementation simply added another author/committer pattern
at the same top-level for ALL-MATCH to insist on matching all, finding
nothing.
Turn
    log --author=me --author=her \
    	--committer=him --committer=you \
	--grep=this --grep=that
into
    (ALL-MATCH
      (OR (HEADER-AUTHOR me) (HEADER-AUTHOR her))
      (OR (HEADER-COMMITTER him) (HEADER-COMMITTER you))
      (OR (PATTERN this) (PATTERN that)))
instead.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
	
		
			
				
	
	
		
			121 lines
		
	
	
		
			2.7 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			121 lines
		
	
	
		
			2.7 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
#ifndef GREP_H
 | 
						|
#define GREP_H
 | 
						|
#include "color.h"
 | 
						|
 | 
						|
enum grep_pat_token {
 | 
						|
	GREP_PATTERN,
 | 
						|
	GREP_PATTERN_HEAD,
 | 
						|
	GREP_PATTERN_BODY,
 | 
						|
	GREP_AND,
 | 
						|
	GREP_OPEN_PAREN,
 | 
						|
	GREP_CLOSE_PAREN,
 | 
						|
	GREP_NOT,
 | 
						|
	GREP_OR
 | 
						|
};
 | 
						|
 | 
						|
enum grep_context {
 | 
						|
	GREP_CONTEXT_HEAD,
 | 
						|
	GREP_CONTEXT_BODY
 | 
						|
};
 | 
						|
 | 
						|
enum grep_header_field {
 | 
						|
	GREP_HEADER_AUTHOR = 0,
 | 
						|
	GREP_HEADER_COMMITTER
 | 
						|
};
 | 
						|
#define GREP_HEADER_FIELD_MAX (GREP_HEADER_COMMITTER + 1)
 | 
						|
 | 
						|
struct grep_pat {
 | 
						|
	struct grep_pat *next;
 | 
						|
	const char *origin;
 | 
						|
	int no;
 | 
						|
	enum grep_pat_token token;
 | 
						|
	const char *pattern;
 | 
						|
	size_t patternlen;
 | 
						|
	enum grep_header_field field;
 | 
						|
	regex_t regexp;
 | 
						|
	unsigned fixed:1;
 | 
						|
	unsigned ignore_case:1;
 | 
						|
	unsigned word_regexp:1;
 | 
						|
};
 | 
						|
 | 
						|
enum grep_expr_node {
 | 
						|
	GREP_NODE_ATOM,
 | 
						|
	GREP_NODE_NOT,
 | 
						|
	GREP_NODE_AND,
 | 
						|
	GREP_NODE_TRUE,
 | 
						|
	GREP_NODE_OR
 | 
						|
};
 | 
						|
 | 
						|
struct grep_expr {
 | 
						|
	enum grep_expr_node node;
 | 
						|
	unsigned hit;
 | 
						|
	union {
 | 
						|
		struct grep_pat *atom;
 | 
						|
		struct grep_expr *unary;
 | 
						|
		struct {
 | 
						|
			struct grep_expr *left;
 | 
						|
			struct grep_expr *right;
 | 
						|
		} binary;
 | 
						|
	} u;
 | 
						|
};
 | 
						|
 | 
						|
struct grep_opt {
 | 
						|
	struct grep_pat *pattern_list;
 | 
						|
	struct grep_pat **pattern_tail;
 | 
						|
	struct grep_pat *header_list;
 | 
						|
	struct grep_pat **header_tail;
 | 
						|
	struct grep_expr *pattern_expression;
 | 
						|
	const char *prefix;
 | 
						|
	int prefix_length;
 | 
						|
	regex_t regexp;
 | 
						|
	int linenum;
 | 
						|
	int invert;
 | 
						|
	int ignore_case;
 | 
						|
	int status_only;
 | 
						|
	int name_only;
 | 
						|
	int unmatch_name_only;
 | 
						|
	int count;
 | 
						|
	int word_regexp;
 | 
						|
	int fixed;
 | 
						|
	int all_match;
 | 
						|
#define GREP_BINARY_DEFAULT	0
 | 
						|
#define GREP_BINARY_NOMATCH	1
 | 
						|
#define GREP_BINARY_TEXT	2
 | 
						|
	int binary;
 | 
						|
	int extended;
 | 
						|
	int relative;
 | 
						|
	int pathname;
 | 
						|
	int null_following_name;
 | 
						|
	int color;
 | 
						|
	int max_depth;
 | 
						|
	int funcname;
 | 
						|
	char color_context[COLOR_MAXLEN];
 | 
						|
	char color_filename[COLOR_MAXLEN];
 | 
						|
	char color_function[COLOR_MAXLEN];
 | 
						|
	char color_lineno[COLOR_MAXLEN];
 | 
						|
	char color_match[COLOR_MAXLEN];
 | 
						|
	char color_selected[COLOR_MAXLEN];
 | 
						|
	char color_sep[COLOR_MAXLEN];
 | 
						|
	int regflags;
 | 
						|
	unsigned pre_context;
 | 
						|
	unsigned post_context;
 | 
						|
	unsigned last_shown;
 | 
						|
	int show_hunk_mark;
 | 
						|
	void *priv;
 | 
						|
 | 
						|
	void (*output)(struct grep_opt *opt, const void *data, size_t size);
 | 
						|
	void *output_priv;
 | 
						|
};
 | 
						|
 | 
						|
extern void append_grep_pat(struct grep_opt *opt, const char *pat, size_t patlen, const char *origin, int no, enum grep_pat_token t);
 | 
						|
extern void append_grep_pattern(struct grep_opt *opt, const char *pat, const char *origin, int no, enum grep_pat_token t);
 | 
						|
extern void append_header_grep_pattern(struct grep_opt *, enum grep_header_field, const char *);
 | 
						|
extern void compile_grep_patterns(struct grep_opt *opt);
 | 
						|
extern void free_grep_patterns(struct grep_opt *opt);
 | 
						|
extern int grep_buffer(struct grep_opt *opt, const char *name, char *buf, unsigned long size);
 | 
						|
 | 
						|
extern struct grep_opt *grep_opt_dup(const struct grep_opt *opt);
 | 
						|
extern int grep_threads_ok(const struct grep_opt *opt);
 | 
						|
 | 
						|
#endif
 |