The post-rewrite support, in the form of the call to 'record_in_rewritten', was hidden in the arm where we have to record a new commit for the user. This meant that it was never invoked in the case where the user has already amended the commit by herself. [The test is designed to exercise both arms of the 'if' in question.] Furthermore, recording the stopped-sha (the SHA1 of the commit before the editing) suffered from a cut&paste error from die_with_patch and used the wrong variable, hence it never recorded anything. Noticed by Junio. Signed-off-by: Thomas Rast <trast@student.ethz.ch> Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
			
				
	
	
		
			200 lines
		
	
	
		
			4.5 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			200 lines
		
	
	
		
			4.5 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
#!/bin/sh
 | 
						|
#
 | 
						|
# Copyright (c) 2010 Thomas Rast
 | 
						|
#
 | 
						|
 | 
						|
test_description='Test the post-rewrite hook.'
 | 
						|
. ./test-lib.sh
 | 
						|
 | 
						|
test_expect_success 'setup' '
 | 
						|
	test_commit A foo A &&
 | 
						|
	test_commit B foo B &&
 | 
						|
	test_commit C foo C &&
 | 
						|
	test_commit D foo D
 | 
						|
'
 | 
						|
 | 
						|
mkdir .git/hooks
 | 
						|
 | 
						|
cat >.git/hooks/post-rewrite <<EOF
 | 
						|
#!/bin/sh
 | 
						|
echo \$@ > "$TRASH_DIRECTORY"/post-rewrite.args
 | 
						|
cat > "$TRASH_DIRECTORY"/post-rewrite.data
 | 
						|
EOF
 | 
						|
chmod u+x .git/hooks/post-rewrite
 | 
						|
 | 
						|
clear_hook_input () {
 | 
						|
	rm -f post-rewrite.args post-rewrite.data
 | 
						|
}
 | 
						|
 | 
						|
verify_hook_input () {
 | 
						|
	test_cmp "$TRASH_DIRECTORY"/post-rewrite.args expected.args &&
 | 
						|
	test_cmp "$TRASH_DIRECTORY"/post-rewrite.data expected.data
 | 
						|
}
 | 
						|
 | 
						|
test_expect_success 'git commit --amend' '
 | 
						|
	clear_hook_input &&
 | 
						|
	echo "D new message" > newmsg &&
 | 
						|
	oldsha=$(git rev-parse HEAD^0) &&
 | 
						|
	git commit -Fnewmsg --amend &&
 | 
						|
	echo amend > expected.args &&
 | 
						|
	echo $oldsha $(git rev-parse HEAD^0) > expected.data &&
 | 
						|
	verify_hook_input
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git commit --amend --no-post-rewrite' '
 | 
						|
	clear_hook_input &&
 | 
						|
	echo "D new message again" > newmsg &&
 | 
						|
	git commit --no-post-rewrite -Fnewmsg --amend &&
 | 
						|
	test ! -f post-rewrite.args &&
 | 
						|
	test ! -f post-rewrite.data
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git rebase' '
 | 
						|
	git reset --hard D &&
 | 
						|
	clear_hook_input &&
 | 
						|
	test_must_fail git rebase --onto A B &&
 | 
						|
	echo C > foo &&
 | 
						|
	git add foo &&
 | 
						|
	git rebase --continue &&
 | 
						|
	echo rebase >expected.args &&
 | 
						|
	cat >expected.data <<EOF &&
 | 
						|
$(git rev-parse C) $(git rev-parse HEAD^)
 | 
						|
$(git rev-parse D) $(git rev-parse HEAD)
 | 
						|
EOF
 | 
						|
	verify_hook_input
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git rebase --skip' '
 | 
						|
	git reset --hard D &&
 | 
						|
	clear_hook_input &&
 | 
						|
	test_must_fail git rebase --onto A B &&
 | 
						|
	test_must_fail git rebase --skip &&
 | 
						|
	echo D > foo &&
 | 
						|
	git add foo &&
 | 
						|
	git rebase --continue &&
 | 
						|
	echo rebase >expected.args &&
 | 
						|
	cat >expected.data <<EOF &&
 | 
						|
$(git rev-parse D) $(git rev-parse HEAD)
 | 
						|
EOF
 | 
						|
	verify_hook_input
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git rebase -m' '
 | 
						|
	git reset --hard D &&
 | 
						|
	clear_hook_input &&
 | 
						|
	test_must_fail git rebase -m --onto A B &&
 | 
						|
	echo C > foo &&
 | 
						|
	git add foo &&
 | 
						|
	git rebase --continue &&
 | 
						|
	echo rebase >expected.args &&
 | 
						|
	cat >expected.data <<EOF &&
 | 
						|
$(git rev-parse C) $(git rev-parse HEAD^)
 | 
						|
$(git rev-parse D) $(git rev-parse HEAD)
 | 
						|
EOF
 | 
						|
	verify_hook_input
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git rebase -m --skip' '
 | 
						|
	git reset --hard D &&
 | 
						|
	clear_hook_input &&
 | 
						|
	test_must_fail git rebase --onto A B &&
 | 
						|
	test_must_fail git rebase --skip &&
 | 
						|
	echo D > foo &&
 | 
						|
	git add foo &&
 | 
						|
	git rebase --continue &&
 | 
						|
	echo rebase >expected.args &&
 | 
						|
	cat >expected.data <<EOF &&
 | 
						|
$(git rev-parse D) $(git rev-parse HEAD)
 | 
						|
EOF
 | 
						|
	verify_hook_input
 | 
						|
'
 | 
						|
 | 
						|
. "$TEST_DIRECTORY"/lib-rebase.sh
 | 
						|
 | 
						|
set_fake_editor
 | 
						|
 | 
						|
# Helper to work around the lack of one-shot exporting for
 | 
						|
# test_must_fail (as it is a shell function)
 | 
						|
test_fail_interactive_rebase () {
 | 
						|
	(
 | 
						|
		FAKE_LINES="$1" &&
 | 
						|
		shift &&
 | 
						|
		export FAKE_LINES &&
 | 
						|
		test_must_fail git rebase -i "$@"
 | 
						|
	)
 | 
						|
}
 | 
						|
 | 
						|
test_expect_success 'git rebase -i (unchanged)' '
 | 
						|
	git reset --hard D &&
 | 
						|
	clear_hook_input &&
 | 
						|
	test_fail_interactive_rebase "1 2" --onto A B &&
 | 
						|
	echo C > foo &&
 | 
						|
	git add foo &&
 | 
						|
	git rebase --continue &&
 | 
						|
	echo rebase >expected.args &&
 | 
						|
	cat >expected.data <<EOF &&
 | 
						|
$(git rev-parse C) $(git rev-parse HEAD^)
 | 
						|
$(git rev-parse D) $(git rev-parse HEAD)
 | 
						|
EOF
 | 
						|
	verify_hook_input
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git rebase -i (skip)' '
 | 
						|
	git reset --hard D &&
 | 
						|
	clear_hook_input &&
 | 
						|
	test_fail_interactive_rebase "2" --onto A B &&
 | 
						|
	echo D > foo &&
 | 
						|
	git add foo &&
 | 
						|
	git rebase --continue &&
 | 
						|
	echo rebase >expected.args &&
 | 
						|
	cat >expected.data <<EOF &&
 | 
						|
$(git rev-parse D) $(git rev-parse HEAD)
 | 
						|
EOF
 | 
						|
	verify_hook_input
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git rebase -i (squash)' '
 | 
						|
	git reset --hard D &&
 | 
						|
	clear_hook_input &&
 | 
						|
	test_fail_interactive_rebase "1 squash 2" --onto A B &&
 | 
						|
	echo C > foo &&
 | 
						|
	git add foo &&
 | 
						|
	git rebase --continue &&
 | 
						|
	echo rebase >expected.args &&
 | 
						|
	cat >expected.data <<EOF &&
 | 
						|
$(git rev-parse C) $(git rev-parse HEAD)
 | 
						|
$(git rev-parse D) $(git rev-parse HEAD)
 | 
						|
EOF
 | 
						|
	verify_hook_input
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git rebase -i (fixup without conflict)' '
 | 
						|
	git reset --hard D &&
 | 
						|
	clear_hook_input &&
 | 
						|
	FAKE_LINES="1 fixup 2" git rebase -i B &&
 | 
						|
	echo rebase >expected.args &&
 | 
						|
	cat >expected.data <<EOF &&
 | 
						|
$(git rev-parse C) $(git rev-parse HEAD)
 | 
						|
$(git rev-parse D) $(git rev-parse HEAD)
 | 
						|
EOF
 | 
						|
	verify_hook_input
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'git rebase -i (double edit)' '
 | 
						|
	git reset --hard D &&
 | 
						|
	clear_hook_input &&
 | 
						|
	FAKE_LINES="edit 1 edit 2" git rebase -i B &&
 | 
						|
	git rebase --continue &&
 | 
						|
	echo something > foo &&
 | 
						|
	git add foo &&
 | 
						|
	git rebase --continue &&
 | 
						|
	echo rebase >expected.args &&
 | 
						|
	cat >expected.data <<EOF &&
 | 
						|
$(git rev-parse C) $(git rev-parse HEAD^)
 | 
						|
$(git rev-parse D) $(git rev-parse HEAD)
 | 
						|
EOF
 | 
						|
	verify_hook_input
 | 
						|
'
 | 
						|
 | 
						|
test_done
 |