 7ce4c8f752
			
		
	
	7ce4c8f752
	
	
	
		
			
			When parsing server capabilities, we use "int" to store lengths and offsets. At first glance this seems like a spot where our parser may be confused by integer overflow if somebody sent us a malicious response. In practice these strings are all bounded by the 64k limit of a pkt-line, so using "int" is OK. However, it makes the code simpler to audit if they just use size_t everywhere. Note that because we take these parameters as pointers, this also forces many callers to update their declared types. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
			
				
	
	
		
			34 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			34 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| #ifndef CONNECT_H
 | |
| #define CONNECT_H
 | |
| 
 | |
| #include "protocol.h"
 | |
| 
 | |
| #define CONNECT_VERBOSE       (1u << 0)
 | |
| #define CONNECT_DIAG_URL      (1u << 1)
 | |
| #define CONNECT_IPV4          (1u << 2)
 | |
| #define CONNECT_IPV6          (1u << 3)
 | |
| struct child_process *git_connect(int fd[2], const char *url, const char *name, const char *prog, int flags);
 | |
| int finish_connect(struct child_process *conn);
 | |
| int git_connection_is_socket(struct child_process *conn);
 | |
| int server_supports(const char *feature);
 | |
| int parse_feature_request(const char *features, const char *feature);
 | |
| const char *server_feature_value(const char *feature, size_t *len_ret);
 | |
| int url_is_local_not_ssh(const char *url);
 | |
| 
 | |
| struct packet_reader;
 | |
| enum protocol_version discover_version(struct packet_reader *reader);
 | |
| 
 | |
| int server_supports_hash(const char *desired, int *feature_supported);
 | |
| const char *parse_feature_value(const char *feature_list, const char *feature, size_t *lenp, size_t *offset);
 | |
| int server_supports_v2(const char *c);
 | |
| void ensure_server_supports_v2(const char *c);
 | |
| int server_feature_v2(const char *c, const char **v);
 | |
| int server_supports_feature(const char *c, const char *feature,
 | |
| 			    int die_on_error);
 | |
| 
 | |
| void check_stateless_delimiter(int stateless_rpc,
 | |
| 			       struct packet_reader *reader,
 | |
| 			       const char *error);
 | |
| 
 | |
| #endif
 |