7a98d9ab00
Extend the the release_revisions() function so that it frees the "cmdline" in the "struct rev_info". This in combination with a preceding change to free "commits" and "mailmap" means that we can whitelist another test under "TEST_PASSES_SANITIZE_LEAK=true". There was a proposal in [1] to do away with xstrdup()-ing this add_rev_cmdline(), perhaps that would be worthwhile, but for now let's just free() it. We could also make that a "char *" in "struct rev_cmdline_entry" itself, but since we own it let's expose it as a constant to outside callers. I proposed that in [2] but have since changed my mind. See14d30cdfc0(ref-filter: fix memory leak in `free_array_item()`, 2019-07-10),c514c62a4f(checkout: fix leak of non-existent branch names, 2020-08-14) and other log history hits for "free((char *)" for prior art. This includes the tests we had false-positive passes on before my6798b08e84(perl Git.pm: don't ignore signalled failure in _cmd_close(), 2022-02-01), now they pass for real. Since there are 66 tests matching t/t[0-9]*git-svn*.sh it's easier to list those that don't pass than to touch most of those 66. So let's introduce a "TEST_FAILS_SANITIZE_LEAK=true", which if set in the tests won't cause lib-git-svn.sh to set "TEST_PASSES_SANITIZE_LEAK=true. This change also marks all the tests that we removed "TEST_FAILS_SANITIZE_LEAK=true" from in an earlier commit due to removing the UNLEAK() from cmd_format_patch(), we can now assert that its API use doesn't leak any "struct rev_info" memory. This change also made commit "t5503-tagfollow.sh" pass on current master, but that would regress when combined with ps/fetch-atomic-fixup'sde004e848a(t5503: simplify setup of test which exercises failure of backfill, 2022-03-03) (through no fault of that topic, that change started using "git clone" in the test, which has an outstanding leak). Let's leave that test out for now to avoid in-flight semantic conflicts. 1. https://lore.kernel.org/git/YUj%2FgFRh6pwrZalY@carlos-mbp.lan/ 2. https://lore.kernel.org/git/87o88obkb1.fsf@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
293 lines
8.6 KiB
Bash
Executable File
293 lines
8.6 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='difference in submodules'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
. "$TEST_DIRECTORY"/lib-diff.sh
|
|
|
|
test_expect_success setup '
|
|
test_tick &&
|
|
test_create_repo sub &&
|
|
(
|
|
cd sub &&
|
|
echo hello >world &&
|
|
git add world &&
|
|
git commit -m submodule
|
|
) &&
|
|
|
|
test_tick &&
|
|
echo frotz >nitfol &&
|
|
git add nitfol sub &&
|
|
git commit -m superproject &&
|
|
|
|
(
|
|
cd sub &&
|
|
echo goodbye >world &&
|
|
git add world &&
|
|
git commit -m "submodule #2"
|
|
) &&
|
|
|
|
git -C sub rev-list HEAD >revs &&
|
|
set x $(cat revs) &&
|
|
echo ":160000 160000 $3 $ZERO_OID M sub" >expect &&
|
|
subtip=$3 subprev=$2
|
|
'
|
|
|
|
test_expect_success 'git diff --raw HEAD' '
|
|
hexsz=$(test_oid hexsz) &&
|
|
git diff --raw --abbrev=$hexsz HEAD >actual &&
|
|
test_cmp expect actual
|
|
'
|
|
|
|
test_expect_success 'git diff-index --raw HEAD' '
|
|
git diff-index --raw HEAD >actual.index &&
|
|
test_cmp expect actual.index
|
|
'
|
|
|
|
test_expect_success 'git diff-files --raw' '
|
|
git diff-files --raw >actual.files &&
|
|
test_cmp expect actual.files
|
|
'
|
|
|
|
expect_from_to () {
|
|
printf "%sSubproject commit %s\n+Subproject commit %s\n" \
|
|
"-" "$1" "$2"
|
|
}
|
|
|
|
test_expect_success 'git diff HEAD' '
|
|
git diff HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subtip $subprev &&
|
|
test_cmp expect.body actual.body
|
|
'
|
|
|
|
test_expect_success 'git diff HEAD with dirty submodule (work tree)' '
|
|
echo >>sub/world &&
|
|
git diff HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subtip $subprev-dirty &&
|
|
test_cmp expect.body actual.body
|
|
'
|
|
|
|
test_expect_success 'git diff HEAD with dirty submodule (index)' '
|
|
(
|
|
cd sub &&
|
|
git reset --hard &&
|
|
echo >>world &&
|
|
git add world
|
|
) &&
|
|
git diff HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subtip $subprev-dirty &&
|
|
test_cmp expect.body actual.body
|
|
'
|
|
|
|
test_expect_success 'git diff HEAD with dirty submodule (untracked)' '
|
|
(
|
|
cd sub &&
|
|
git reset --hard &&
|
|
git clean -qfdx &&
|
|
>cruft
|
|
) &&
|
|
git diff HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subtip $subprev &&
|
|
test_cmp expect.body actual.body
|
|
'
|
|
|
|
test_expect_success 'git diff HEAD with dirty submodule (untracked) (none ignored)' '
|
|
test_config diff.ignoreSubmodules none &&
|
|
git diff HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subtip $subprev-dirty &&
|
|
test_cmp expect.body actual.body
|
|
'
|
|
|
|
test_expect_success 'git diff HEAD with dirty submodule (work tree, refs match)' '
|
|
git commit -m "x" sub &&
|
|
echo >>sub/world &&
|
|
git diff HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subprev $subprev-dirty &&
|
|
test_cmp expect.body actual.body &&
|
|
git diff --ignore-submodules HEAD >actual2 &&
|
|
test_must_be_empty actual2 &&
|
|
git diff --ignore-submodules=untracked HEAD >actual3 &&
|
|
sed -e "1,/^@@/d" actual3 >actual3.body &&
|
|
expect_from_to >expect.body $subprev $subprev-dirty &&
|
|
test_cmp expect.body actual3.body &&
|
|
git diff --ignore-submodules=dirty HEAD >actual4 &&
|
|
test_must_be_empty actual4
|
|
'
|
|
|
|
test_expect_success 'git diff HEAD with dirty submodule (work tree, refs match) [.gitmodules]' '
|
|
git config diff.ignoreSubmodules dirty &&
|
|
git diff HEAD >actual &&
|
|
test_must_be_empty actual &&
|
|
git config --add -f .gitmodules submodule.subname.ignore none &&
|
|
git config --add -f .gitmodules submodule.subname.path sub &&
|
|
git diff HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subprev $subprev-dirty &&
|
|
test_cmp expect.body actual.body &&
|
|
git config -f .gitmodules submodule.subname.ignore all &&
|
|
git config -f .gitmodules submodule.subname.path sub &&
|
|
git diff HEAD >actual2 &&
|
|
test_must_be_empty actual2 &&
|
|
git config -f .gitmodules submodule.subname.ignore untracked &&
|
|
git diff HEAD >actual3 &&
|
|
sed -e "1,/^@@/d" actual3 >actual3.body &&
|
|
expect_from_to >expect.body $subprev $subprev-dirty &&
|
|
test_cmp expect.body actual3.body &&
|
|
git config -f .gitmodules submodule.subname.ignore dirty &&
|
|
git diff HEAD >actual4 &&
|
|
test_must_be_empty actual4 &&
|
|
git config submodule.subname.ignore none &&
|
|
git config submodule.subname.path sub &&
|
|
git diff HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subprev $subprev-dirty &&
|
|
test_cmp expect.body actual.body &&
|
|
git config --remove-section submodule.subname &&
|
|
git config --remove-section -f .gitmodules submodule.subname &&
|
|
git config --unset diff.ignoreSubmodules &&
|
|
rm .gitmodules
|
|
'
|
|
|
|
test_expect_success 'git diff HEAD with dirty submodule (index, refs match)' '
|
|
(
|
|
cd sub &&
|
|
git reset --hard &&
|
|
echo >>world &&
|
|
git add world
|
|
) &&
|
|
git diff HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subprev $subprev-dirty &&
|
|
test_cmp expect.body actual.body
|
|
'
|
|
|
|
test_expect_success 'git diff HEAD with dirty submodule (untracked, refs match)' '
|
|
(
|
|
cd sub &&
|
|
git reset --hard &&
|
|
git clean -qfdx &&
|
|
>cruft
|
|
) &&
|
|
git diff --ignore-submodules=none HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subprev $subprev-dirty &&
|
|
test_cmp expect.body actual.body &&
|
|
git diff --ignore-submodules=all HEAD >actual2 &&
|
|
test_must_be_empty actual2 &&
|
|
git diff HEAD >actual3 &&
|
|
test_must_be_empty actual3 &&
|
|
git diff --ignore-submodules=dirty HEAD >actual4 &&
|
|
test_must_be_empty actual4
|
|
'
|
|
|
|
test_expect_success 'git diff HEAD with dirty submodule (untracked, refs match) [.gitmodules]' '
|
|
git config --add -f .gitmodules submodule.subname.ignore all &&
|
|
git config --add -f .gitmodules submodule.subname.path sub &&
|
|
git diff HEAD >actual2 &&
|
|
test_must_be_empty actual2 &&
|
|
git config -f .gitmodules submodule.subname.ignore untracked &&
|
|
git diff HEAD >actual3 &&
|
|
test_must_be_empty actual3 &&
|
|
git config -f .gitmodules submodule.subname.ignore dirty &&
|
|
git diff HEAD >actual4 &&
|
|
test_must_be_empty actual4 &&
|
|
git config submodule.subname.ignore none &&
|
|
git config submodule.subname.path sub &&
|
|
git diff HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subprev $subprev-dirty &&
|
|
test_cmp expect.body actual.body &&
|
|
git config --remove-section submodule.subname &&
|
|
git config --remove-section -f .gitmodules submodule.subname &&
|
|
rm .gitmodules
|
|
'
|
|
|
|
test_expect_success 'git diff between submodule commits' '
|
|
git diff HEAD^..HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subtip $subprev &&
|
|
test_cmp expect.body actual.body &&
|
|
git diff --ignore-submodules=dirty HEAD^..HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subtip $subprev &&
|
|
test_cmp expect.body actual.body &&
|
|
git diff --ignore-submodules HEAD^..HEAD >actual &&
|
|
test_must_be_empty actual
|
|
'
|
|
|
|
test_expect_success 'git diff between submodule commits [.gitmodules]' '
|
|
git diff HEAD^..HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subtip $subprev &&
|
|
test_cmp expect.body actual.body &&
|
|
git config --add -f .gitmodules submodule.subname.ignore dirty &&
|
|
git config --add -f .gitmodules submodule.subname.path sub &&
|
|
git diff HEAD^..HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subtip $subprev &&
|
|
test_cmp expect.body actual.body &&
|
|
git config -f .gitmodules submodule.subname.ignore all &&
|
|
git diff HEAD^..HEAD >actual &&
|
|
test_must_be_empty actual &&
|
|
git config submodule.subname.ignore dirty &&
|
|
git config submodule.subname.path sub &&
|
|
git diff HEAD^..HEAD >actual &&
|
|
sed -e "1,/^@@/d" actual >actual.body &&
|
|
expect_from_to >expect.body $subtip $subprev &&
|
|
git config --remove-section submodule.subname &&
|
|
git config --remove-section -f .gitmodules submodule.subname &&
|
|
rm .gitmodules
|
|
'
|
|
|
|
test_expect_success 'git diff (empty submodule dir)' '
|
|
rm -rf sub/* sub/.git &&
|
|
git diff > actual.empty &&
|
|
test_must_be_empty actual.empty
|
|
'
|
|
|
|
test_expect_success 'conflicted submodule setup' '
|
|
c=$(test_oid ff_1) &&
|
|
(
|
|
echo "000000 $ZERO_OID 0 sub" &&
|
|
echo "160000 1$c 1 sub" &&
|
|
echo "160000 2$c 2 sub" &&
|
|
echo "160000 3$c 3 sub"
|
|
) | git update-index --index-info &&
|
|
echo >expect.nosub "diff --cc sub
|
|
index 2ffffff,3ffffff..0000000
|
|
--- a/sub
|
|
+++ b/sub
|
|
@@@ -1,1 -1,1 +1,1 @@@
|
|
- Subproject commit 2$c
|
|
-Subproject commit 3$c
|
|
++Subproject commit $ZERO_OID" &&
|
|
|
|
hh=$(git rev-parse HEAD) &&
|
|
sed -e "s/$ZERO_OID/$hh/" expect.nosub >expect.withsub
|
|
|
|
'
|
|
|
|
test_expect_success 'combined (empty submodule)' '
|
|
rm -fr sub && mkdir sub &&
|
|
git diff >actual &&
|
|
test_cmp expect.nosub actual
|
|
'
|
|
|
|
test_expect_success 'combined (with submodule)' '
|
|
rm -fr sub &&
|
|
git clone --no-checkout . sub &&
|
|
git diff >actual &&
|
|
test_cmp expect.withsub actual
|
|
'
|
|
|
|
|
|
|
|
test_done
|