mirrors/git
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
4c6f781f9c7ee7029c3f2fd20ddd76ce8b476bca
git/builtin
History
Jeff King 4c6f781f9c format-patch: refactor output selection 
The --stdout and --output-directory options are mutually exclusive, but
it's hard to tell from reading the code. We have three separate
conditionals that check for use_stdout, and it's only after we've set up
the output_directory fully that we check whether the user also specified
--stdout.

Instead, let's check the exclusion explicitly first, then have a single
conditional that handles stdout versus an output directory. This is
slightly easier to follow now, and also will keep things sane when we
add another output mode in a future patch.

We'll add a few tests as well, covering the mutual exclusion and the
fact that we are not confused by a configured output directory.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-11-04 14:05:28 -08:00
..
add.c
drop unused argc parameters
2020-09-30 12:53:47 -07:00
am.c
Merge branch 'jk/committer-date-is-author-date-fix' into maint
2020-10-29 14:18:47 -07:00
annotate.c
strvec: rename struct fields
2020-07-30 19:18:06 -07:00
apply.c
…
archive.c
…
bisect--helper.c
Merge branch 'mr/bisect-in-c-2'
2020-10-04 12:49:08 -07:00
blame.c
Merge branch 'jc/blame-ignore-fix'
2020-10-04 12:49:07 -07:00
branch.c
ref-filter: allow merged and no-merged filters
2020-09-16 12:38:10 -07:00
bugreport.c
Merge branch 'jk/slimmed-down'
2020-09-03 12:37:02 -07:00
bundle.c
Merge branch 'bc/sha-256-part-3'
2020-08-11 18:04:11 -07:00
cat-file.c
Merge branch 'cc/cat-file-usage-update' into master
2020-07-09 14:00:41 -07:00
check-attr.c
…
check-ignore.c
dir: fix problematic API to avoid memory leaks
2020-08-18 17:17:31 -07:00
check-mailmap.c
…
check-ref-format.c
…
checkout-index.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
checkout.c
Merge branch 'jt/interpret-branch-name-fallback'
2020-09-09 13:53:09 -07:00
clean.c
quote_path: give flags parameter to quote_path()
2020-09-10 10:49:19 -07:00
clone.c
builtin/clone: avoid failure with GIT_DEFAULT_HASH
2020-09-22 09:22:32 -07:00
column.c
…
commit-graph.c
assert PARSE_OPT_NONEG in parse-options callbacks
2020-09-30 12:53:47 -07:00
commit-tree.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
commit.c
drop unused argc parameters
2020-09-30 12:53:47 -07:00
config.c
Merge branch 'ls/mergetool-meld-auto-merge'
2020-09-22 12:36:29 -07:00
count-objects.c
…
credential-cache--daemon.c
make credential helpers builtins
2020-08-13 11:02:08 -07:00
credential-cache.c
Merge branch 'jc/undash-in-tree-git-callers'
2020-09-03 12:37:03 -07:00
credential-store.c
make credential helpers builtins
2020-08-13 11:02:08 -07:00
credential.c
…
describe.c
strvec: rename struct fields
2020-07-30 19:18:06 -07:00
diff-files.c
diff-files: treat "i-t-a" files as "not-in-index"
2020-06-22 10:46:45 -07:00
diff-index.c
…
diff-tree.c
diff-tree.c: load notes machinery when required
2020-04-20 18:22:54 -07:00
diff.c
diff: get rid of redundant 'dense' argument
2020-09-29 11:54:53 -07:00
difftool.c
strvec: rename struct fields
2020-07-30 19:18:06 -07:00
env--helper.c
assert PARSE_OPT_NONEG in parse-options callbacks
2020-09-30 12:53:47 -07:00
fast-export.c
Merge branch 'js/default-branch-name-part-2'
2020-10-05 14:01:50 -07:00
fast-import.c
fast-import: use write_pack_header()
2020-09-06 13:40:37 -07:00
fetch-pack.c
fetch-pack: remove no_dependents code
2020-08-18 16:46:53 -07:00
fetch.c
Merge branch 'jk/refspecs-negative'
2020-10-05 14:01:54 -07:00
fmt-merge-msg.c
Lib-ify fmt-merge-msg
2020-03-24 15:04:43 -07:00
for-each-ref.c
ref-filter: allow merged and no-merged filters
2020-09-16 12:38:10 -07:00
fsck.c
fsck: do not lazy fetch known non-promisor object
2020-08-06 13:01:03 -07:00
gc.c
maintenance: add trace2 regions for task execution
2020-09-17 11:30:05 -07:00
get-tar-commit-id.c
…
grep.c
quote_path: give flags parameter to quote_path()
2020-09-10 10:49:19 -07:00
hash-object.c
…
help.c
help: drop usage of 'common' and 'useful' for guides
2020-08-04 18:34:01 -07:00
index-pack.c
Merge branch 'jk/index-pack-hotfixes'
2020-10-08 21:53:26 -07:00
init-db.c
builtin/clone: avoid failure with GIT_DEFAULT_HASH
2020-09-22 09:22:32 -07:00
interpret-trailers.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
log.c
format-patch: refactor output selection
2020-11-04 14:05:28 -08:00
ls-files.c
dir: fix problematic API to avoid memory leaks
2020-08-18 17:17:31 -07:00
ls-remote.c
Merge branch 'jk/unleak-fixes'
2020-08-24 14:54:30 -07:00
ls-tree.c
…
mailinfo.c
…
mailsplit.c
…
merge-base.c
rebase: --fork-point regression fix
2020-02-11 09:59:39 -08:00
merge-file.c
…
merge-index.c
…
merge-ours.c
…
merge-recursive.c
…
merge-tree.c
…
merge.c
Merge branch 'ds/maintenance-part-1'
2020-09-25 15:25:38 -07:00
mktag.c
sha1-file: allow check_object_signature() to handle any repo
2020-01-31 10:45:39 -08:00
mktree.c
…
multi-pack-index.c
…
mv.c
git-mv: improve error message for conflicted file
2020-07-20 14:35:43 -07:00
name-rev.c
messages: avoid SHA-1 in end-user facing messages
2020-08-14 09:33:37 -07:00
notes.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
pack-objects.c
Merge branch 'jc/object-names-are-not-sha-1'
2020-08-19 16:14:52 -07:00
pack-redundant.c
…
pack-refs.c
…
patch-id.c
patch-id: use oid_to_hex() to print multiple object IDs
2019-12-09 12:26:40 -08:00
prune-packed.c
Lib-ify prune-packed
2020-03-24 15:04:44 -07:00
prune.c
Merge branch 'tb/shallow-cleanup'
2020-05-13 12:19:18 -07:00
pull.c
Merge branch 'ah/pull'
2020-09-29 14:01:22 -07:00
push.c
push: drop unused repo argument to do_push()
2020-09-30 12:53:47 -07:00
range-diff.c
strvec: convert builtin/ callers away from argv_array name
2020-07-28 15:02:18 -07:00
read-tree.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
rebase.c
Merge branch 'ds/maintenance-part-1'
2020-09-25 15:25:38 -07:00
receive-pack.c
Merge branch 'jx/proc-receive-hook'
2020-09-25 15:25:39 -07:00
reflog.c
Merge branch 'es/get-worktrees-unsort'
2020-07-06 22:09:15 -07:00
remote-ext.c
strvec: convert builtin/ callers away from argv_array name
2020-07-28 15:02:18 -07:00
remote-fd.c
…
remote.c
Merge branch 'cs/don-t-pretend-a-failed-remote-set-head-succeeded'
2020-09-22 12:36:32 -07:00
repack.c
Merge branch 'tb/repack-clearing-midx'
2020-09-09 13:53:06 -07:00
replace.c
strvec: rename struct fields
2020-07-30 19:18:06 -07:00
rerere.c
…
reset.c
wt-status: tolerate dangling marks
2020-09-02 14:39:25 -07:00
rev-list.c
bisect: combine args passed to find_bisection()
2020-08-07 15:13:03 -07:00
rev-parse.c
wt-status: tolerate dangling marks
2020-09-02 14:39:25 -07:00
revert.c
…
rm.c
rm: support the --pathspec-from-file option
2020-02-19 10:56:49 -08:00
send-pack.c
Merge branch 'jx/proc-receive-hook'
2020-09-25 15:25:39 -07:00
shortlog.c
shortlog: allow multiple groups to be specified
2020-09-27 12:21:05 -07:00
show-branch.c
Merge branch 'jt/interpret-branch-name-fallback'
2020-09-09 13:53:09 -07:00
show-index.c
builtin/show-index: provide options to determine hash algo
2020-05-27 10:07:07 -07:00
show-ref.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
sparse-checkout.c
sparse-checkout: fill in some options boilerplate
2020-09-30 12:53:48 -07:00
stash.c
Merge branch 'jt/interpret-branch-name-fallback'
2020-09-09 13:53:09 -07:00
stripspace.c
…
submodule--helper.c
doc: fix the bnf like style of some commands
2020-10-08 14:01:19 -07:00
symbolic-ref.c
…
tag.c
ref-filter: allow merged and no-merged filters
2020-09-16 12:38:10 -07:00
unpack-file.c
…
unpack-objects.c
sha1-file: pass git_hash_algo to hash_object_file()
2020-01-31 10:45:39 -08:00
update-index.c
Use OPT_CALLBACK and OPT_CALLBACK_F
2020-04-28 10:47:10 -07:00
update-ref.c
strvec: rename files from argv-array to strvec
2020-07-28 15:02:17 -07:00
update-server-info.c
…
upload-archive.c
strvec: rename struct fields
2020-07-30 19:18:06 -07:00
upload-pack.c
…
var.c
…
verify-commit.c
…
verify-pack.c
Merge branch 'bc/sha-256-part-3'
2020-08-11 18:04:11 -07:00
verify-tag.c
…
worktree.c
Merge branch 'es/wt-add-detach'
2020-09-18 17:58:04 -07:00
write-tree.c
…