Extend the the release_revisions() function so that it frees the "filter" in the "struct rev_info". This in combination with a preceding change to free "cmdline" means that we can mark another set of tests as passing under "TEST_PASSES_SANITIZE_LEAK=true". The "filter" member was added recently inffaa137f64(revision: put object filter into struct rev_info, 2022-03-09), and this fixes leaks intruded in the subsequent leak7940941de1(pack-objects: use rev.filter when possible, 2022-03-09) and105c6f14ad(bundle: parse filter capability, 2022-03-09). The "builtin/pack-objects.c" leak in7940941de1was effectively with us already, but the variable was referred to by a "static" file-scoped variable. The "bundle.c " leak in105c6f14adwas newly introduced with the new "filter" feature for bundles. The "t5600-clone-fail-cleanup.sh" change here to add "TEST_PASSES_SANITIZE_LEAK=true" is one of the cases where run-command.c in not carrying the abort() exit code upwards would have had that test passing before, but now it *actually* passes[1]. We should fix the lack of 1=1 mapping of SANITIZE=leak testing to actual leaks some other time, but it's an existing edge case, let's just mark the really-passing test as passing for now. 1. https://lore.kernel.org/git/220303.86fsnz5o9w.gmgdl@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
			
				
	
	
		
			65 lines
		
	
	
		
			1.5 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			65 lines
		
	
	
		
			1.5 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
#!/bin/sh
 | 
						|
 | 
						|
test_description='checkout from unborn branch'
 | 
						|
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 | 
						|
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 | 
						|
 | 
						|
TEST_PASSES_SANITIZE_LEAK=true
 | 
						|
. ./test-lib.sh
 | 
						|
 | 
						|
test_expect_success 'setup' '
 | 
						|
	mkdir parent &&
 | 
						|
	(cd parent &&
 | 
						|
	 git init &&
 | 
						|
	 echo content >file &&
 | 
						|
	 git add file &&
 | 
						|
	 git commit -m base
 | 
						|
	) &&
 | 
						|
	git fetch parent main:origin
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'checkout from unborn preserves untracked files' '
 | 
						|
	echo precious >expect &&
 | 
						|
	echo precious >file &&
 | 
						|
	test_must_fail git checkout -b new origin &&
 | 
						|
	test_cmp expect file
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'checkout from unborn preserves index contents' '
 | 
						|
	echo precious >expect &&
 | 
						|
	echo precious >file &&
 | 
						|
	git add file &&
 | 
						|
	test_must_fail git checkout -b new origin &&
 | 
						|
	test_cmp expect file &&
 | 
						|
	git show :file >file &&
 | 
						|
	test_cmp expect file
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'checkout from unborn merges identical index contents' '
 | 
						|
	echo content >file &&
 | 
						|
	git add file &&
 | 
						|
	git checkout -b new origin
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'checking out another branch from unborn state' '
 | 
						|
	git checkout --orphan newroot &&
 | 
						|
	git checkout -b anothername &&
 | 
						|
	test_must_fail git show-ref --verify refs/heads/newroot &&
 | 
						|
	git symbolic-ref HEAD >actual &&
 | 
						|
	echo refs/heads/anothername >expect &&
 | 
						|
	test_cmp expect actual
 | 
						|
'
 | 
						|
 | 
						|
test_expect_success 'checking out in a newly created repo' '
 | 
						|
	test_create_repo empty &&
 | 
						|
	(
 | 
						|
		cd empty &&
 | 
						|
		git symbolic-ref HEAD >expect &&
 | 
						|
		test_must_fail git checkout &&
 | 
						|
		git symbolic-ref HEAD >actual &&
 | 
						|
		test_cmp expect actual
 | 
						|
	)
 | 
						|
'
 | 
						|
 | 
						|
test_done
 |