 47d72a74a7
			
		
	
	47d72a74a7
	
	
	
		
			
			The `struct diff_flags` structure is essentially an array of flags, all of which have the same type. We can thus use `sizeof()` to iterate through all of the flags, which we do in `diff_flags_or()`. But while the statement returns an unsigned integer, we used a signed integer to iterate through the flags, which generates a warning. Fix this by using `size_t` for the index instead. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
			
				
	
	
		
			75 lines
		
	
	
		
			1.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			75 lines
		
	
	
		
			1.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * test-revision-walking.c: test revision walking API.
 | |
|  *
 | |
|  * (C) 2012 Heiko Voigt <hvoigt@hvoigt.net>
 | |
|  *
 | |
|  * This code is free software; you can redistribute it and/or modify
 | |
|  * it under the terms of the GNU General Public License version 2 as
 | |
|  * published by the Free Software Foundation.
 | |
|  */
 | |
| 
 | |
| #define USE_THE_REPOSITORY_VARIABLE
 | |
| 
 | |
| #include "test-tool.h"
 | |
| #include "commit.h"
 | |
| #include "diff.h"
 | |
| #include "repository.h"
 | |
| #include "revision.h"
 | |
| #include "setup.h"
 | |
| 
 | |
| static void print_commit(struct commit *commit)
 | |
| {
 | |
| 	struct strbuf sb = STRBUF_INIT;
 | |
| 	struct pretty_print_context ctx = {0};
 | |
| 	ctx.date_mode.type = DATE_NORMAL;
 | |
| 	repo_format_commit_message(the_repository, commit, " %m %s", &sb,
 | |
| 				   &ctx);
 | |
| 	printf("%s\n", sb.buf);
 | |
| 	strbuf_release(&sb);
 | |
| }
 | |
| 
 | |
| static int run_revision_walk(void)
 | |
| {
 | |
| 	struct rev_info rev;
 | |
| 	struct commit *commit;
 | |
| 	const char *argv[] = {NULL, "--all", NULL};
 | |
| 	int argc = ARRAY_SIZE(argv) - 1;
 | |
| 	int got_revision = 0;
 | |
| 
 | |
| 	repo_init_revisions(the_repository, &rev, NULL);
 | |
| 	setup_revisions(argc, argv, &rev, NULL);
 | |
| 	if (prepare_revision_walk(&rev))
 | |
| 		die("revision walk setup failed");
 | |
| 
 | |
| 	while ((commit = get_revision(&rev)) != NULL) {
 | |
| 		print_commit(commit);
 | |
| 		got_revision = 1;
 | |
| 	}
 | |
| 
 | |
| 	reset_revision_walk();
 | |
| 	release_revisions(&rev);
 | |
| 	return got_revision;
 | |
| }
 | |
| 
 | |
| int cmd__revision_walking(int argc, const char **argv)
 | |
| {
 | |
| 	if (argc < 2)
 | |
| 		return 1;
 | |
| 
 | |
| 	setup_git_directory();
 | |
| 
 | |
| 	if (!strcmp(argv[1], "run-twice")) {
 | |
| 		printf("1st\n");
 | |
| 		if (!run_revision_walk())
 | |
| 			return 1;
 | |
| 		printf("2nd\n");
 | |
| 		if (!run_revision_walk())
 | |
| 			return 1;
 | |
| 
 | |
| 		return 0;
 | |
| 	}
 | |
| 
 | |
| 	fprintf(stderr, "check usage\n");
 | |
| 	return 1;
 | |
| }
 |