 c33ddc2e33
			
		
	
	c33ddc2e33
	
	
	
		
			
			Many of the date functions write into fixed-size buffers.
This is a minor pain, as we have to take special
precautions, and frequently end up copying the result into a
strbuf or heap-allocated buffer anyway (for which we
sometimes use strcpy!).
Let's instead teach parse_date, datestamp, etc to write to a
strbuf. The obvious downside is that we might need to
perform a heap allocation where we otherwise would not need
to. However, it turns out that the only two new allocations
required are:
  1. In test-date.c, where we don't care about efficiency.
  2. In determine_author_info, which is not performance
     critical (and where the use of a strbuf will help later
     refactoring).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
	
		
			
				
	
	
		
			74 lines
		
	
	
		
			1.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			74 lines
		
	
	
		
			1.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| #include "cache.h"
 | |
| 
 | |
| static const char *usage_msg = "\n"
 | |
| "  test-date show [time_t]...\n"
 | |
| "  test-date parse [date]...\n"
 | |
| "  test-date approxidate [date]...\n";
 | |
| 
 | |
| static void show_dates(char **argv, struct timeval *now)
 | |
| {
 | |
| 	struct strbuf buf = STRBUF_INIT;
 | |
| 
 | |
| 	for (; *argv; argv++) {
 | |
| 		time_t t = atoi(*argv);
 | |
| 		show_date_relative(t, 0, now, &buf);
 | |
| 		printf("%s -> %s\n", *argv, buf.buf);
 | |
| 	}
 | |
| 	strbuf_release(&buf);
 | |
| }
 | |
| 
 | |
| static void parse_dates(char **argv, struct timeval *now)
 | |
| {
 | |
| 	struct strbuf result = STRBUF_INIT;
 | |
| 
 | |
| 	for (; *argv; argv++) {
 | |
| 		unsigned long t;
 | |
| 		int tz;
 | |
| 
 | |
| 		strbuf_reset(&result);
 | |
| 		parse_date(*argv, &result);
 | |
| 		if (sscanf(result.buf, "%lu %d", &t, &tz) == 2)
 | |
| 			printf("%s -> %s\n",
 | |
| 			       *argv, show_date(t, tz, DATE_ISO8601));
 | |
| 		else
 | |
| 			printf("%s -> bad\n", *argv);
 | |
| 	}
 | |
| 	strbuf_release(&result);
 | |
| }
 | |
| 
 | |
| static void parse_approxidate(char **argv, struct timeval *now)
 | |
| {
 | |
| 	for (; *argv; argv++) {
 | |
| 		time_t t;
 | |
| 		t = approxidate_relative(*argv, now);
 | |
| 		printf("%s -> %s\n", *argv, show_date(t, 0, DATE_ISO8601));
 | |
| 	}
 | |
| }
 | |
| 
 | |
| int main(int argc, char **argv)
 | |
| {
 | |
| 	struct timeval now;
 | |
| 	const char *x;
 | |
| 
 | |
| 	x = getenv("TEST_DATE_NOW");
 | |
| 	if (x) {
 | |
| 		now.tv_sec = atoi(x);
 | |
| 		now.tv_usec = 0;
 | |
| 	}
 | |
| 	else
 | |
| 		gettimeofday(&now, NULL);
 | |
| 
 | |
| 	argv++;
 | |
| 	if (!*argv)
 | |
| 		usage(usage_msg);
 | |
| 	if (!strcmp(*argv, "show"))
 | |
| 		show_dates(argv+1, &now);
 | |
| 	else if (!strcmp(*argv, "parse"))
 | |
| 		parse_dates(argv+1, &now);
 | |
| 	else if (!strcmp(*argv, "approxidate"))
 | |
| 		parse_approxidate(argv+1, &now);
 | |
| 	else
 | |
| 		usage(usage_msg);
 | |
| 	return 0;
 | |
| }
 |