 aa1c6fdf47
			
		
	
	aa1c6fdf47
	
	
	
		
			
			There are several utility functions (hashcmp and friends) that are used for comparing object IDs (SHA-1 values). Using these functions, which take pointers to unsigned char, with struct object_id requires tiresome access to the sha1 member, which bloats code and violates the desired encapsulation. Provide wrappers around these functions for struct object_id for neater, more maintainable code. Use the new constants to avoid the hard-coded 20s and 40s throughout the original functions. These functions simply call the underlying pointer-to-unsigned-char versions to ensure that any performance improvements will be passed through to the new functions. Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
			
				
	
	
		
			86 lines
		
	
	
		
			2.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			86 lines
		
	
	
		
			2.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| #include "cache.h"
 | |
| 
 | |
| const signed char hexval_table[256] = {
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 00-07 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 08-0f */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 10-17 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 18-1f */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 20-27 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 28-2f */
 | |
| 	  0,  1,  2,  3,  4,  5,  6,  7,		/* 30-37 */
 | |
| 	  8,  9, -1, -1, -1, -1, -1, -1,		/* 38-3f */
 | |
| 	 -1, 10, 11, 12, 13, 14, 15, -1,		/* 40-47 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 48-4f */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 50-57 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 58-5f */
 | |
| 	 -1, 10, 11, 12, 13, 14, 15, -1,		/* 60-67 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 68-67 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 70-77 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 78-7f */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 80-87 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 88-8f */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 90-97 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* 98-9f */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* a0-a7 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* a8-af */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* b0-b7 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* b8-bf */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* c0-c7 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* c8-cf */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* d0-d7 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* d8-df */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* e0-e7 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* e8-ef */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* f0-f7 */
 | |
| 	 -1, -1, -1, -1, -1, -1, -1, -1,		/* f8-ff */
 | |
| };
 | |
| 
 | |
| int get_sha1_hex(const char *hex, unsigned char *sha1)
 | |
| {
 | |
| 	int i;
 | |
| 	for (i = 0; i < GIT_SHA1_RAWSZ; i++) {
 | |
| 		unsigned int val;
 | |
| 		/*
 | |
| 		 * hex[1]=='\0' is caught when val is checked below,
 | |
| 		 * but if hex[0] is NUL we have to avoid reading
 | |
| 		 * past the end of the string:
 | |
| 		 */
 | |
| 		if (!hex[0])
 | |
| 			return -1;
 | |
| 		val = (hexval(hex[0]) << 4) | hexval(hex[1]);
 | |
| 		if (val & ~0xff)
 | |
| 			return -1;
 | |
| 		*sha1++ = val;
 | |
| 		hex += 2;
 | |
| 	}
 | |
| 	return 0;
 | |
| }
 | |
| 
 | |
| int get_oid_hex(const char *hex, struct object_id *oid)
 | |
| {
 | |
| 	return get_sha1_hex(hex, oid->hash);
 | |
| }
 | |
| 
 | |
| char *sha1_to_hex(const unsigned char *sha1)
 | |
| {
 | |
| 	static int bufno;
 | |
| 	static char hexbuffer[4][GIT_SHA1_HEXSZ + 1];
 | |
| 	static const char hex[] = "0123456789abcdef";
 | |
| 	char *buffer = hexbuffer[3 & ++bufno], *buf = buffer;
 | |
| 	int i;
 | |
| 
 | |
| 	for (i = 0; i < GIT_SHA1_RAWSZ; i++) {
 | |
| 		unsigned int val = *sha1++;
 | |
| 		*buf++ = hex[val >> 4];
 | |
| 		*buf++ = hex[val & 0xf];
 | |
| 	}
 | |
| 	*buf = '\0';
 | |
| 
 | |
| 	return buffer;
 | |
| }
 | |
| 
 | |
| char *oid_to_hex(const struct object_id *oid)
 | |
| {
 | |
| 	return sha1_to_hex(oid->hash);
 | |
| }
 |