 0c51d6b4ae
			
		
	
	0c51d6b4ae
	
	
	
		
			
			Failures within `for` and `while` loops can go unnoticed if not detected and signaled manually since the loop itself does not abort when a contained command fails, nor will a failure necessarily be detected when the loop finishes since the loop returns the exit code of the last command it ran on the final iteration, which may not be the command which failed. Therefore, detect and signal failures manually within loops using the idiom `|| return 1` (or `|| exit 1` within subshells). Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Reviewed-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
		
			
				
	
	
		
			41 lines
		
	
	
		
			754 B
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			41 lines
		
	
	
		
			754 B
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
| #!/bin/sh
 | |
| #
 | |
| # Copyright (c) 2009 Robert Zeh
 | |
| 
 | |
| test_description='git svn creates empty directories, calls git gc, makes sure they are still empty'
 | |
| . ./lib-git-svn.sh
 | |
| 
 | |
| test_expect_success 'initialize repo' '
 | |
| 	for i in a b c d d/e d/e/f "weird file name"
 | |
| 	do
 | |
| 		svn_cmd mkdir -m "mkdir $i" "$svnrepo"/"$i" || return 1
 | |
| 	done
 | |
| '
 | |
| 
 | |
| test_expect_success 'clone' 'git svn clone "$svnrepo" cloned'
 | |
| 
 | |
| test_expect_success 'git svn gc runs' '
 | |
| 	(
 | |
| 		cd cloned &&
 | |
| 		git svn gc
 | |
| 	)
 | |
| '
 | |
| 
 | |
| test_expect_success 'git svn mkdirs recreates empty directories after git svn gc' '
 | |
| 	(
 | |
| 		cd cloned &&
 | |
| 		rm -r * &&
 | |
| 		git svn mkdirs &&
 | |
| 		for i in a b c d d/e d/e/f "weird file name"
 | |
| 		do
 | |
| 			if ! test -d "$i"
 | |
| 			then
 | |
| 				echo >&2 "$i does not exist" &&
 | |
| 				exit 1
 | |
| 			fi
 | |
| 		done
 | |
| 	)
 | |
| '
 | |
| 
 | |
| test_done
 |