7c10605d2c
Built-in merge tools contain a hard-coded assumption about whether or not a tool's exit code can be trusted to determine the success or failure of a merge. Tools whose exit codes are not trusted contain calls to check_unchanged() in their merge_cmd() functions. A problem with this is that the trustExitCode configuration is not honored for built-in tools. Teach built-in tools to honor the trustExitCode configuration. Extend run_merge_cmd() so that it is responsible for calling check_unchanged() when a tool's exit code cannot be trusted. Remove check_unchanged() calls from scriptlets since they are no longer responsible for calling it. When no configuration is present, exit_code_trustable() is checked to see whether the exit code should be trusted. The default implementation returns false. Tools whose exit codes can be trusted override exit_code_trustable() to true. Reported-by: Dun Peal <dunpealer@gmail.com> Signed-off-by: David Aguilar <davvid@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
16 lines
361 B
Plaintext
16 lines
361 B
Plaintext
diff_cmd () {
|
|
"$merge_tool_path" -u -e "$LOCAL" "$REMOTE"
|
|
return 0
|
|
}
|
|
|
|
merge_cmd () {
|
|
# mergetool.winmerge.trustExitCode is implicitly false.
|
|
# touch $BACKUP so that we can check_unchanged.
|
|
"$merge_tool_path" -u -e -dl Local -dr Remote \
|
|
"$LOCAL" "$REMOTE" "$MERGED"
|
|
}
|
|
|
|
translate_merge_tool_path() {
|
|
mergetool_find_win32_cmd "WinMergeU.exe" "WinMerge"
|
|
}
|