fe191fcaa5
git-svn by default puts its Subversion-tracking refs directly in refs/remotes/*. This runs counter to Git's convention of using refs/remotes/$remote/* for storing remote-tracking branches. Furthermore, combining git-svn with regular git remotes run the risk of clobbering refs under refs/remotes (e.g. if you have a git remote called "tags" with a "v1" branch, it will overlap with the git-svn's tracking branch for the "v1" tag from Subversion. Even though the git-svn refs stored in refs/remotes/* are not "proper" remote-tracking branches (since they are not covered by a proper git remote's refspec), they clearly represent a similar concept, and would benefit from following the same convention. For example, if git-svn tracks Subversion branch "foo" at refs/remotes/foo, and you create a local branch refs/heads/foo to add some commits to be pushed back to Subversion (using "git svn dcommit), then it is clearly unhelpful of Git to throw warning: refname 'foo' is ambiguous. every time you checkout, rebase, or otherwise interact with the branch. The existing workaround for this is to supply the --prefix=quux/ to git svn init/clone, so that git-svn's tracking branches end up in refs/remotes/quux/* instead of refs/remotes/*. However, encouraging users to specify --prefix to work around a design flaw in git-svn is suboptimal, and not a long term solution to the problem. Instead, git-svn should default to use a non-empty prefix that saves unsuspecting users from the inconveniences described above. This patch will only affect newly created git-svn setups, as the --prefix option only applies to git svn init (and git svn clone). Existing git-svn setups will continue with their existing (lack of) prefix. Also, if anyone somehow prefers git-svn's old layout, they can recreate that by explicitly passing an empty prefix (--prefix "") on the git svn init/clone command line. The patch changes the default value for --prefix from "" to "origin/", updates the git-svn manual page, and fixes the fallout in the git-svn testcases. (Note that this patch might be easier to review using the --word-diff and --word-diff-regex=. diff options.) [ew: squashed description of <= 1.9 behavior into manpage] Suggested-by: Thomas Ferris Nicolaisen <tfnico@gmail.com> Signed-off-by: Johan Herland <johan@herland.net> Signed-off-by: Eric Wong <normalperson@yhbt.net>
96 lines
2.7 KiB
Bash
Executable File
96 lines
2.7 KiB
Bash
Executable File
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2007 Eric Wong
|
|
# Based on a script by Joakim Tjernlund <joakim.tjernlund@transmode.se>
|
|
|
|
test_description='git svn dcommit handles merges'
|
|
|
|
. ./lib-git-svn.sh
|
|
|
|
big_text_block () {
|
|
cat << EOF
|
|
#
|
|
# (C) Copyright 2000 - 2005
|
|
# Wolfgang Denk, DENX Software Engineering, wd@denx.de.
|
|
#
|
|
# See file CREDITS for list of people who contributed to this
|
|
# project.
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License as
|
|
# published by the Free Software Foundation; either version 2 of
|
|
# the License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
|
|
# MA 02111-1307 USA
|
|
#
|
|
EOF
|
|
}
|
|
|
|
test_expect_success 'setup svn repository' '
|
|
svn_cmd co "$svnrepo" mysvnwork &&
|
|
mkdir -p mysvnwork/trunk &&
|
|
(
|
|
cd mysvnwork &&
|
|
big_text_block >>trunk/README &&
|
|
svn_cmd add trunk &&
|
|
svn_cmd ci -m "first commit" trunk
|
|
)
|
|
'
|
|
|
|
test_expect_success 'setup git mirror and merge' '
|
|
git svn init "$svnrepo" -t tags -T trunk -b branches &&
|
|
git svn fetch &&
|
|
git checkout -b svn remotes/origin/trunk &&
|
|
git checkout -b merge &&
|
|
echo new file > new_file &&
|
|
git add new_file &&
|
|
git commit -a -m "New file" &&
|
|
echo hello >> README &&
|
|
git commit -a -m "hello" &&
|
|
echo add some stuff >> new_file &&
|
|
git commit -a -m "add some stuff" &&
|
|
git checkout svn &&
|
|
mv -f README tmp &&
|
|
echo friend > README &&
|
|
cat tmp >> README &&
|
|
git commit -a -m "friend" &&
|
|
git merge merge
|
|
'
|
|
|
|
test_debug 'gitk --all & sleep 1'
|
|
|
|
test_expect_success 'verify pre-merge ancestry' "
|
|
test x\`git rev-parse --verify refs/heads/svn^2\` = \
|
|
x\`git rev-parse --verify refs/heads/merge\` &&
|
|
git cat-file commit refs/heads/svn^ | grep '^friend$'
|
|
"
|
|
|
|
test_expect_success 'git svn dcommit merges' "
|
|
git svn dcommit
|
|
"
|
|
|
|
test_debug 'gitk --all & sleep 1'
|
|
|
|
test_expect_success 'verify post-merge ancestry' "
|
|
test x\`git rev-parse --verify refs/heads/svn\` = \
|
|
x\`git rev-parse --verify refs/remotes/origin/trunk \` &&
|
|
test x\`git rev-parse --verify refs/heads/svn^2\` = \
|
|
x\`git rev-parse --verify refs/heads/merge\` &&
|
|
git cat-file commit refs/heads/svn^ | grep '^friend$'
|
|
"
|
|
|
|
test_expect_success 'verify merge commit message' "
|
|
git rev-list --pretty=raw -1 refs/heads/svn | \
|
|
grep \" Merge branch 'merge' into svn\"
|
|
"
|
|
|
|
test_done
|