2f0ee051dd
While the return parameter of `write_rev_file_order()` is a string constant, the function may indeed return an allocated string when its first parameter is a `NULL` pointer. This makes for a confusing calling convention, where callers need to be aware of these intricate ownership rules and cast away the constness to free the string in some cases. Adapt the function and its caller `write_rev_file()` to always return an allocated string and adapt callers to always free the return value. Note that this requires us to also adapt `rename_tmp_packfile()`, which compares the pointers to packfile data with each other. Now that the path of the reverse index file gets allocated unconditionally the check will always fail. This is fixed by using strcmp(3P) instead, which also feels way less fragile. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
45 lines
1014 B
Bash
Executable File
45 lines
1014 B
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='exercise basic multi-pack bitmap functionality (.rev files)'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
. "${TEST_DIRECTORY}/lib-bitmap.sh"
|
|
|
|
# We'll be writing our own MIDX, so avoid getting confused by the automatic
|
|
# ones.
|
|
GIT_TEST_MULTI_PACK_INDEX=0
|
|
GIT_TEST_MULTI_PACK_INDEX_WRITE_INCREMENTAL=0
|
|
|
|
# Unlike t5326, this test exercise multi-pack bitmap functionality where the
|
|
# object order is stored in a separate .rev file.
|
|
GIT_TEST_MIDX_WRITE_REV=1
|
|
GIT_TEST_MIDX_READ_RIDX=0
|
|
export GIT_TEST_MIDX_WRITE_REV
|
|
export GIT_TEST_MIDX_READ_RIDX
|
|
|
|
test_midx_bitmap_rev () {
|
|
writeLookupTable=false
|
|
|
|
for i in "$@"
|
|
do
|
|
case $i in
|
|
"pack.writeBitmapLookupTable") writeLookupTable=true;;
|
|
esac
|
|
done
|
|
|
|
test_expect_success 'setup bitmap config' '
|
|
rm -rf * .git &&
|
|
git init &&
|
|
git config pack.writeBitmapLookupTable '"$writeLookupTable"'
|
|
'
|
|
|
|
midx_bitmap_core rev
|
|
midx_bitmap_partial_tests rev
|
|
}
|
|
|
|
test_midx_bitmap_rev
|
|
test_midx_bitmap_rev "pack.writeBitmapLookupTable"
|
|
|
|
test_done
|