fba95dad6a
There are a bunch of tests which do not have any leaks: - t0411: Introduced via5c5a4a1c05(t0411: add tests for cloning from partial repo, 2024-01-28), passes since its inception. - t0610: Introduced via57db2a094d(refs: introduce reftable backend, 2024-02-07), passes since its inception. - t2405: Passes since6741e917de(repository: avoid leaking `fsmonitor` data, 2024-04-12). - t7423: Introduced viab20c10fd9b(t7423: add tests for symlinked submodule directories, 2024-01-28), passes sincee8d0608944(submodule: require the submodule path to contain directories only, 2024-03-26). The fix is not obviously related, but probably works because we now die early in many code paths. - t9xxx: All of these are exercising CVS-related tooling and pass since at least Git v2.40. It's likely that these pass for a long time already, but nobody ever noticed because Git developers do not tend to have CVS on their machines. Mark all of these tests as passing. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
80 lines
2.6 KiB
Bash
Executable File
80 lines
2.6 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
test_description='check that local clone does not fetch from promisor remotes'
|
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
|
. ./test-lib.sh
|
|
|
|
test_expect_success 'create evil repo' '
|
|
git init tmp &&
|
|
test_commit -C tmp a &&
|
|
git -C tmp config uploadpack.allowfilter 1 &&
|
|
git clone --filter=blob:none --no-local --no-checkout tmp evil &&
|
|
rm -rf tmp &&
|
|
|
|
git -C evil config remote.origin.uploadpack \"\$TRASH_DIRECTORY/fake-upload-pack\" &&
|
|
write_script fake-upload-pack <<-\EOF &&
|
|
echo >&2 "fake-upload-pack running"
|
|
>"$TRASH_DIRECTORY/script-executed"
|
|
exit 1
|
|
EOF
|
|
export TRASH_DIRECTORY &&
|
|
|
|
# empty shallow file disables local clone optimization
|
|
>evil/.git/shallow
|
|
'
|
|
|
|
test_expect_success 'local clone must not fetch from promisor remote and execute script' '
|
|
rm -f script-executed &&
|
|
test_must_fail git clone \
|
|
--upload-pack="GIT_TEST_ASSUME_DIFFERENT_OWNER=true git-upload-pack" \
|
|
evil clone1 2>err &&
|
|
test_grep "detected dubious ownership" err &&
|
|
test_grep ! "fake-upload-pack running" err &&
|
|
test_path_is_missing script-executed
|
|
'
|
|
|
|
test_expect_success 'clone from file://... must not fetch from promisor remote and execute script' '
|
|
rm -f script-executed &&
|
|
test_must_fail git clone \
|
|
--upload-pack="GIT_TEST_ASSUME_DIFFERENT_OWNER=true git-upload-pack" \
|
|
"file://$(pwd)/evil" clone2 2>err &&
|
|
test_grep "detected dubious ownership" err &&
|
|
test_grep ! "fake-upload-pack running" err &&
|
|
test_path_is_missing script-executed
|
|
'
|
|
|
|
test_expect_success 'fetch from file://... must not fetch from promisor remote and execute script' '
|
|
rm -f script-executed &&
|
|
test_must_fail git fetch \
|
|
--upload-pack="GIT_TEST_ASSUME_DIFFERENT_OWNER=true git-upload-pack" \
|
|
"file://$(pwd)/evil" 2>err &&
|
|
test_grep "detected dubious ownership" err &&
|
|
test_grep ! "fake-upload-pack running" err &&
|
|
test_path_is_missing script-executed
|
|
'
|
|
|
|
test_expect_success 'pack-objects should fetch from promisor remote and execute script' '
|
|
rm -f script-executed &&
|
|
echo "HEAD" | test_must_fail git -C evil pack-objects --revs --stdout >/dev/null 2>err &&
|
|
test_grep "fake-upload-pack running" err &&
|
|
test_path_is_file script-executed
|
|
'
|
|
|
|
test_expect_success 'clone from promisor remote does not lazy-fetch by default' '
|
|
rm -f script-executed &&
|
|
test_must_fail git clone evil no-lazy 2>err &&
|
|
test_grep "lazy fetching disabled" err &&
|
|
test_path_is_missing script-executed
|
|
'
|
|
|
|
test_expect_success 'promisor lazy-fetching can be re-enabled' '
|
|
rm -f script-executed &&
|
|
test_must_fail env GIT_NO_LAZY_FETCH=0 \
|
|
git clone evil lazy-ok 2>err &&
|
|
test_grep "fake-upload-pack running" err &&
|
|
test_path_is_file script-executed
|
|
'
|
|
|
|
test_done
|